Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Superfluous parameters #21

Open
lkubb opened this issue May 29, 2024 · 0 comments
Open

[BUG] Superfluous parameters #21

lkubb opened this issue May 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@lkubb
Copy link
Member

lkubb commented May 29, 2024

Description
Several functions in this extension take an api_version parameter, which is completely ignored.
The (superfluous) state module exposes a sound parameter, which is ignored.
The query utils func exposes token, which is ignored.

Steps to Reproduce the behavior
Set api_version to anything and see the extension still working.

Expected behavior
Don't expose parameters which do nothing.

There is only a single API version. We don't know how a successor will be structured, so we cannot assume the module code to just work. Only the query util func should retain the parameter for custom modules.

@lkubb lkubb added the bug Something isn't working label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant