Poor support for Debian 9

[bogdanr]

Installing nginx with this formula on Debian 9 does a bunch of stuff which are not as a Debian admin would expect them to be. Just to name a few:

File /var/log/nginx/access.log is set for removal
File /var/log/nginx/error.log is set for removal
File /etc/logrotate.d/nginx is set for removal
The following packages would be installed/updated: apache2-utils
File "/etc/init.d/nginx" is set to be moved to "/usr/share/nginx/init.d"
The file or directory /etc/init.d/nginx is set for removal to make way for a new symlink targeting /lib/init/upstart-job

[danmac-uk]

I'm using it on Debian 9 with none of these issues, but then I went with the default Debian package. Might be worth clarifying if you are installing from source, whether a previous nginx package was installed, etc. (the proposed removal of /etc/init.d/nginx and reference to upstart seems very odd)

The only issue I'm having is the service not reloading after a config change but I haven't really dug into the problem to see if it's me or the formula yet. (I'm new to Salt and I jumped in the deep end a bit)

[daks]

@danmac-uk in fact it seems that service is not reloaded automatically, I opened #194 to track it

[arthurzenika]

@bogdanr we're using nginx formula quite extensively with debian stretch, never encountered these issues. Do you have more information to help us debug ?

[noelmcloughlin]

@bogdanr Seems these relate to nginx state not nginx.ng state.

These get triggered by nginx.use_upstart: True (or maybe use_sysvinit: True).

File /var/log/nginx/access.log is set for removal
File /var/log/nginx/error.log is set for removal
File /etc/logrotate.d/nginx is set for removal

And these when nginx.install_from_source: True (& maybe use_sysvinit: True).

The following packages would be installed/updated: apache2-utils
File "/etc/init.d/nginx" is set to be moved to "/usr/share/nginx/init.d"
The file or directory /etc/init.d/nginx is set for removal to make way for a new symlink targeting /lib/init/upstart-job

I guess best solution is to use ngninx.ng state instead or don't install from source.

[noelmcloughlin]

Hi @aboe76 @javierbertoli

Should we update name.init.sls so it points directly at name.ng.init.sls to improve quality in this formula and maybe others?