script_args global config not respected

[ErisDS]

My cloud config looked like this:

cloud:
    script_args: stable 2017.7.8 
    provider: do
    minion:
      master: x.x.x.x

    providers:
      digital_ocean.conf:
        do:
          driver: digital_ocean

I was expecting that doing state.apply would result in the script_args line in /etc/salt/cloud would be updated.

Changing the config to

cloud:
    provider: do
    minion:
      master: x.x.x.x

    providers:
      digital_ocean.conf:
        do:
          driver: digital_ocean
          script_args: stable 2017.7.8 

Correctly updates /etc/salt/cloud.providers.d/digital_ocean.conf and works.

However I'd expect that it would be possible to override the global value in /etc/salt/cloud/.

Caveat: i might be wrong about /etc/salt/cloud being the right place to honour this - in our system we have a script_args line in there, but it may have been hardcoded before we started using salt-formula.

The main point is that this config option is only respected within individual providers, and there is extremely limited documentation around that makes it clear this is how to configure script_args.

The fundamental point being needing to hardcode the minion to not fall behind the master.

[myii]

Thanks for opening this issue @ErisDS. Let me offer some general feedback as a starting point.

I was expecting that doing state.apply would result in the script_args line in /etc/salt/cloud would be updated.

The policy throughout this formula is not to touch the default configuration files such as:

• /etc/salt/cloud
• /etc/salt/master
• /etc/salt/minion

Instead, any overrides/customisations are applied in .conf files in the /etc/salt/*.d/ directories.

Caveat: i might be wrong about /etc/salt/cloud being the right place to honour this - in our system we have a script_args line in there, but it may have been hardcoded before we started using salt-formula.

The current source file doesn't provide script_args, so you're probably right. What's the configuration option you have in your /etc/salt/cloud file?

The main point is that this config option is only respected within individual providers, and there is extremely limited documentation around that makes it clear this is how to configure script_args.

This search provides a few definitions and a number of examples, such as:

• "script_args can be specified in either the profile or the map file, to pass arguments to the deploy script"
• "Script arguments to be fed to the bootstrap script when deploying the VM"
• "arguments which are given to the bootstrap script"
• Examples: 1, 2, 3 -- as a side-note, all of these use provider, size, image and script_args.