Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

section_order ignored #65

Open
spirritus opened this issue Jul 17, 2019 · 4 comments
Open

section_order ignored #65

spirritus opened this issue Jul 17, 2019 · 4 comments

Comments

@spirritus
Copy link

spirritus commented Jul 17, 2019

If you specify section_order: ['global'] to only create the global entries for smb.conf this setting is ignored; global, printers and homes (in that order) are always created.

@myii
Copy link
Member

myii commented Jul 21, 2019

@spirritus This could be due to this line:

{%- if samba.conf.render.get('include_unordered_sections', True) -%}

Which is yes by default:

include_unordered_sections: yes

Have you tried setting this to no in your pillar as well as the change you mentioned above?

@spirritus
Copy link
Author

He myii, thx for the info, salt is still a bit new to me. That line fixed it.

@noelmcloughlin
Copy link
Member

Hi @spirritus
Is "include_unordered_sections: no" a better default? If the current default is unexpected then I'd like to fix that. I'm interested in opinion from Samba user.

@spirritus
Copy link
Author

spirritus commented Jul 22, 2019

Well, I guess it would be a better default. If you specify a list, then you would expect the list to define what is present and nothing else, unless you specify it with another parameter.

edit: would also delete ''wins support = yes' from default.yaml.
excerpt from the docu:

     wins support (G)

          This boolean controls if the nmbd(8) process in Samba will act as a WINS server. You should not set
          this to yes unless you have a multi-subnetted network and you wish a particular nmbd to be your WINS
          server. Note that you should NEVER set this to yes on more than one machine in your network.

          Default: wins support = no

noelmcloughlin added a commit to noelmcloughlin/samba-formula that referenced this issue Jul 22, 2019
noelmcloughlin added a commit to noelmcloughlin/samba-formula that referenced this issue Jul 22, 2019
noelmcloughlin added a commit that referenced this issue Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants