We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
755
CC: @kmosher @jynolen @daks.
#70 was merged quickly due to a regression but it appears that the directory mode should have been set to 755:
sudoers-formula/sudoers/included.sls
Line 16 in 9c7ef40
@daks Mentioned an InSpec test that could also be added:
#70 (comment)
Not sure why I set it to 440 but in fact on Debian 9 or 10 it's 755 so no problem for me to merge this PR as soon as possible. One improvement could be to add a basic test on this directory mode, here https://github.com/saltstack-formulas/sudoers-formula/blob/master/test/integration/default/controls/config.rb, with something like describe directory('/etc/sudoers.d/') do it { should be_owned_by 'root' } it { should be_grouped_into 'root' } its('mode') { should cmp '0755' } end A better one (but I'm not sure I know how to run it) would be to set some NOPASSWD sudo rules and try to use it.
Not sure why I set it to 440 but in fact on Debian 9 or 10 it's 755 so no problem for me to merge this PR as soon as possible.
440
One improvement could be to add a basic test on this directory mode, here https://github.com/saltstack-formulas/sudoers-formula/blob/master/test/integration/default/controls/config.rb, with something like
describe directory('/etc/sudoers.d/') do it { should be_owned_by 'root' } it { should be_grouped_into 'root' } its('mode') { should cmp '0755' } end
A better one (but I'm not sure I know how to run it) would be to set some NOPASSWD sudo rules and try to use it.
NOPASSWD
The text was updated successfully, but these errors were encountered:
No branches or pull requests
CC: @kmosher @jynolen @daks.
#70 was merged quickly due to a regression but it appears that the directory mode should have been set to
755
:sudoers-formula/sudoers/included.sls
Line 16 in 9c7ef40
@daks Mentioned an InSpec test that could also be added:
#70 (comment)
The text was updated successfully, but these errors were encountered: