Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directives for sudo_rules and sudo_defaults appear commented out #149

Open
alexander-bauer opened this issue May 29, 2017 · 2 comments
Open

Comments

@alexander-bauer
Copy link

Hi all, I'm a bit confused. I'm trying to apply sudo_rules and sudo_defaults, but noticed that the state declarations appear to be commented out in users/init.sls. These comments were added in 819d73a, and their functionality doesn't appear to be replicated anywhere else. Can someone explain why this was?

@noelmcloughlin
Copy link
Member

Hi @alexander-bauer
Jinja will process {# as comment but will not interpret #{#% as a comment? I'm not sure what was intended but the jinja inside the if/endif block should be evaluated.

@mdschmitt
Copy link

This might be a little off-topic, but it seems that init.sls is unnecessarily bloated. For instance, I see a bunch of cmd.run stuff relating to the creation of a valid sudoers.d/username, where I think it should just use the check_cmd param of file.managed...?
https://docs.saltproject.io/en/latest/ref/states/all/salt.states.file.html#salt.states.file.managed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants