Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return all pages #7

Open
lholmquist opened this issue Jan 5, 2015 · 1 comment
Open

return all pages #7

lholmquist opened this issue Jan 5, 2015 · 1 comment

Comments

@lholmquist
Copy link
Contributor

example, when you currently request "all" poeple, swapi.getPerson() it will only return the first 10 results and you have to page through the rest.

i think we can pass in an option hash such as:

{
    id: '1',
    pagedResults: all
}

or something like that, so the returned value will be all the results.

@NoahDavidATL
Copy link

That would be nice. Also, getPlanets is missing from this API, but it exists in SWAPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants