Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specification of annotations for the smbshare service #332

Open
jpflouret opened this issue Mar 2, 2024 · 1 comment
Open

Allow specification of annotations for the smbshare service #332

jpflouret opened this issue Mar 2, 2024 · 1 comment

Comments

@jpflouret
Copy link

Adding annotations to the created servcie would allow for additional configuration of the created service. For example, with metallb you could specify the requested address pool to use. Another use case could be specifying the hostname to use with external-dns for registering the load balancer assigned IP address with an external DNS provider (which would address #147).

I would propose that the SmbCommonConfig resource should contain an annotations key either under network or under a new different key. Perhaps serviceSettings could be a sibling of podSettings and it could contain additional settings for the service (e.g. loadBalancerIP).

@phlogistonjohn
Copy link
Collaborator

Sounds generally reasonable to me. Having an annotations under network sounds fine to me. To be super clear we could also consider serviceAnnotations (also under network).

Please note that I have very little time for samba-operator myself these days, so depending on how strongly you want this you may want to look into implementing it yourself or finding someone. I am, of course, happy to review PRs and offer advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants