Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NTACLs (vfs_acl_xattr) in containerized smbd. Currently, acl_xattr requires CAP_SYS_ADMIN which is undesirable. #10

Open
gd opened this issue Sep 7, 2021 · 6 comments
Assignees

Comments

@gd
Copy link

gd commented Sep 7, 2021

Preliminary work has been started to make the xattr attribute name configureable:
https://gitlab.com/samba-team/samba/-/merge_requests/1908

@gd gd self-assigned this Sep 7, 2021
@gd
Copy link
Author

gd commented Sep 23, 2021

Current patch has been deferred (Ralph wants to use a real not a parametric option for performance reason)

@gd
Copy link
Author

gd commented Jun 16, 2022

New merge request (in favor of old one): https://gitlab.com/samba-team/samba/-/merge_requests/2557

@anoopcs9
Copy link
Collaborator

anoopcs9 commented Jul 7, 2022

Now that required changes are in master, let's decide on a xattr name for storing NTACLs using newly added option acl_xattr:security_acl_name.

@gd @phlogistonjohn @spuiuk

@phlogistonjohn
Copy link
Collaborator

Sure. I propose user.ntacl

@anoopcs9
Copy link
Collaborator

Relevant section from upcoming 4.18 Samba release:

New option to change the NT ACL default location
------------------------------------------------

Usually the NT ACLs are stored in the security.NTACL extended
attribute (xattr) of files and directories. The new
"acl_xattr:security_acl_name" option allows to redefine the default
location. The default "security.NTACL" is a protected location, which
means the content of the security.NTACL attribute is not accessible
from normal users outside of Samba. When this option is set to use a
user-defined value, e.g. user.NTACL then any user can potentially
access and overwrite this information. The module prevents access to
this xattr over SMB, but the xattr may still be accessed by other
means (eg local access, SSH, NFS). This option must only be used when
this consequence is clearly understood and when specific precautions
are taken to avoid compromising the ACL content.

@spuiuk @phlogistonjohn Please vote for our preferred xattr name.

@anoopcs9
Copy link
Collaborator

Sure. I propose user.ntacl

user.NTACL 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Idea
Development

No branches or pull requests

3 participants