Fixed: maradns fails to compile with LTO

[eli-schwartz]

With the following in *FLAGS:

-flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

the build fails with the following error:

x86_64-pc-linux-gnu-gcc -march=native -fstack-protector-all -O2 -pipe -fdiagnostics-color=always -frecord-gcc-switches -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-clash-protection -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing  -Wformat -Werror=format-security -Werror=implicit-function-declaration -Werror=implicit-int -Werror=int-conversion -Werror=incompatible-pointer-types  -Wl,-O1 -Wl,--as-needed -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing -Wl,--defsym=__gentoo_check_ldflags__=0  -march=native -fstack-protector-all -O2 -pipe -fdiagnostics-color=always -frecord-gcc-switches -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-clash-protection -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing  -Wformat -Werror=format-security -Werror=implicit-function-declaration -Werror=implicit-int -Werror=int-conversion -Werror=incompatible-pointer-types -Wall -o Deadwood DwMain.c DwStr.o DwMararc.o DwRadioGatun.o DwSocket.o DwUdpSocket.o DwTcpSocket.o DwBlockHash.o DwHalfSipHash.o DwSys.o DwHash.o DwCompress.o DwDnsStr.o DwRecurse.o DwDict.o -lrt
DwSys.c:62:16: error: type of ‘maradns_gid’ does not match original declaration [-Werror=lto-type-mismatch]
   62 | extern int32_t maradns_gid;
      |                ^
DwSocket.c:79:14: note: type ‘int_fast32_t’ should match type ‘int32_t’
   79 | int_fast32_t maradns_gid = 99;
      |              ^
DwSocket.c:79:14: note: ‘maradns_gid’ was previously declared here
DwSocket.c:79:14: note: code may be misoptimized unless ‘-fno-strict-aliasing’ is used
DwSys.c:61:16: error: type of ‘maradns_uid’ does not match original declaration [-Werror=lto-type-mismatch]
   61 | extern int32_t maradns_uid;
      |                ^
DwSocket.c:78:14: note: type ‘int_fast32_t’ should match type ‘int32_t’
   78 | int_fast32_t maradns_uid = 99;
      |              ^
DwSocket.c:78:14: note: ‘maradns_uid’ was previously declared here
DwSocket.c:78:14: note: code may be misoptimized unless ‘-fno-strict-aliasing’ is used
DwUdpSocket.c:59:12: error: type of ‘num_ports’ does not match original declaration [-Werror=lto-type-mismatch]
   59 | extern int num_ports;
      |            ^
DwSocket.c:77:14: note: type ‘int_fast32_t’ should match type ‘int’
   77 | int_fast32_t num_ports = 4096;
      |              ^
DwSocket.c:77:14: note: ‘num_ports’ was previously declared here
DwSocket.c:77:14: note: code may be misoptimized unless ‘-fno-strict-aliasing’ is used
DwUdpSocket.c:58:12: error: type of ‘min_bind’ does not match original declaration [-Werror=lto-type-mismatch]
   58 | extern int min_bind;
      |            ^
DwSocket.c:76:14: note: type ‘int_fast32_t’ should match type ‘int’
   76 | int_fast32_t min_bind = 15000;
      |              ^
DwSocket.c:76:14: note: ‘min_bind’ was previously declared here
DwSocket.c:76:14: note: code may be misoptimized unless ‘-fno-strict-aliasing’ is used
DwUdpSocket.c:55:12: error: type of ‘upstream_port’ does not match original declaration [-Werror=lto-type-mismatch]
   55 | extern int upstream_port;
      |            ^
DwSocket.c:72:14: note: type ‘int_fast32_t’ should match type ‘int’
   72 | int_fast32_t upstream_port = 53;
      |              ^
DwSocket.c:72:14: note: ‘upstream_port’ was previously declared here
DwSocket.c:72:14: note: code may be misoptimized unless ‘-fno-strict-aliasing’ is used
lto1: some warnings being treated as errors
lto-wrapper: fatal error: x86_64-pc-linux-gnu-gcc returned 1 exit status
compilation terminated.
/usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: error: lto-wrapper failed

Originally reported at https://bugs.gentoo.org/861293

Full logs: build.log

[samboy]

Reproduced in the deadwood-github/src directory:

export FLAGS="-flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing" ; make

[samboy]

I’m using cygwin and whatever version of Gcc that comes with, and I’m seeing the same thing.

[samboy]

Fixed.

[samboy]

See commit d828cdf for the fix.