Add route to show stats about page visits #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,3 +49,17 @@ | |||
| flash[:error_title] = 'Unable to locate link' | |||
| redirect '/' | |||
| end | |||
|
|
|||
| get '/:page_hash/stats' do | |||
There was a problem hiding this comment.
Suggested change
| get '/:page_hash/stats' do | |
| get '/:id/stats' do |
| @@ -72,5 +72,47 @@ | |||
| page.must_have_content 'Unable to locate link' | |||
| end | |||
| end | |||
|
|
|||
| get '/:page_hash/stats' do | ||
| @page_hash = params['page_hash'] | ||
|
|
||
| @stats = GetShortUrlStatsService.new(@page_hash).get_stats |
There was a problem hiding this comment.
Suggested change
| @stats = GetShortUrlStatsService.new(@page_hash).get_stats | |
| @stats = ShortUrlStatsService.new(@page_hash).stats |
| @page = ShortUrlByHashService.new(page_hash).find | ||
| end | ||
|
|
||
| def get_stats |
There was a problem hiding this comment.
Suggested change
| def get_stats | |
| def stats | |
| page_visits = PageVisit.where(page_id: page.id) | |
| visits_count = page_visits.count | |
| { | |
| target_url: page.target_url, | |
| visits_count: visits_count, | |
| recent_visits: page_visits.select(:visited_at).order(Sequel.desc(:visited_at)).limit(3).map(&:visited_at), | |
| visits_message: visits_count > 0 ? "Visits: #{visits_count}" : 'This link has no visits yet' | |
| } | |
| end |
| @@ -0,0 +1,9 @@ | |||
| <p>URL: <%= @page_hash %></p> | |||
| <p>Target: <%= @stats[:target_url] %></p> | |||
| <p><%= @visits_message %></p> | |||
There was a problem hiding this comment.
Suggested change
| <p><%= @visits_message %></p> | |
| <p><%= @stats[:visits_message] %></p> |
|
|
||
| @stats = GetShortUrlStatsService.new(@page_hash).get_stats | ||
|
|
||
| if @stats[:visits_count] > 0 |
There was a problem hiding this comment.
I think this logic could live within the service
| @@ -0,0 +1,21 @@ | |||
| class GetShortUrlStatsService | |||
There was a problem hiding this comment.
I think specs are missing for this service
| end | ||
|
|
||
| describe 'and has some stats' do | ||
| it '' do |
There was a problem hiding this comment.
Suggested change
| it '' do | |
| it 'display the number of visits' do |
| end | ||
| end | ||
|
|
||
| describe 'when there is not a page associated with the link' do |
There was a problem hiding this comment.
Suggested change
| describe 'when there is not a page associated with the link' do | |
| describe 'when the page is found' do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3