-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't seem to work. What am I doing wrong? #46
Comments
This is because the library is hooked on the dependency property for |
This loosely addresses #46 but I think an emoji:Run object would be preferable.
Not sure if you are still interested, but there are new features in Emoji.Wpf v0.3.4 that make it now very easy. In private static Run Run(string text)
{
var run = new Run(ConvertXmlEntities(text));
run.Loaded += (o, e) => (o as Run).SubstituteGlyphs();
return run;
} This is the result: |
Much nicer. I am noticing a performance hit on rendering. Scrolling in my program is janky when using Emoji.Wpf |
I noticed that, too. The profiling tools I have access to have much improved and I am currently having a closer look at performance. There have already been improvements (see #63) but unfortunately I don’t think they will apply to Tweetz. |
I peeked at your code and didn't see anything obvious that could be improved. The emoji rendering is pretty expensive I imagine. Thanks for your efforts. |
FYI I have created a new sample program ( I will close this issue because it is not directly related to performance, but you’ll be able to track progress in #63. |
Reusing a |
Added to my WPF project and updated .XAML accordingly. Still seeing b/w emojis.
I pushed my code to https://github.com/mike-ward/tweetz (master branch).
Maybe someone can point out the error of my ways? 😕
Running on Windows 10
The text was updated successfully, but these errors were encountered: