Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black doesn't render for multiple flags #77

Open
janbuijs91 opened this issue Apr 26, 2024 · 3 comments
Open

Black doesn't render for multiple flags #77

janbuijs91 opened this issue Apr 26, 2024 · 3 comments

Comments

@janbuijs91
Copy link

I'm not seeing the black color in multiple flags, like Germany or Belgium.
Here's a screenshot of how Germany is showing up for me:
image

Looking at the source code for the flags, the Brush property isn't defined for some GeometryDrawing lines in multiple flags and I guess it should show up as black in that case, but for me it just doesn't show anything.

@PsychoDad9999
Copy link

I had the same issue a while ago and added PR #73 to fix the german flag. I didn't noticed other flags were affected too.

@janbuijs91
Copy link
Author

Okay thanks for the reply. Guess I'll just clone the repo and add a brush to all GeometryDrawing elements which don't have a brush assigned. Any reason why you used #383838 instead of black?

@PsychoDad9999
Copy link

PsychoDad9999 commented Apr 30, 2024

Sounds good. #383838 is used in Win10Flags.xaml, thats the reason why I used that instead of black.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants