feat: add alt text to all template img elements (#8)

samrum · web-flow · commit d7b13f53b775 · 2022-02-09T21:13:43.000-08:00
diff --git a/template/framework/preact-ts/src/components/PageContent.tsx b/template/framework/preact-ts/src/components/PageContent.tsx
@@ -9,7 +9,7 @@ function PageHeader(props) {
 
   return (
     <div>
-      <img src={imageUrl} height="45" />
+      <img src={imageUrl} height="45" alt="" />
       <h1>{props.children}</h1>
       <button type="button" onClick={() => setCount((count) => count + 1)}>
         Count: {count}
diff --git a/template/framework/preact-ts/src/entries/contentScript/primary/App.tsx b/template/framework/preact-ts/src/entries/contentScript/primary/App.tsx
@@ -6,7 +6,7 @@ function App() {
 
   return (
     <div class="logo">
-      <img src={logoImageUrl} height="50" />
+      <img src={logoImageUrl} height="50" alt="" />
     </div>
   );
 }
diff --git a/template/framework/preact/src/components/PageContent.jsx b/template/framework/preact/src/components/PageContent.jsx
@@ -9,7 +9,7 @@ function PageContent(props) {
 
   return (
     <div>
-      <img src={imageUrl} height="45" />
+      <img src={imageUrl} height="45" alt="" />
       <h1>{props.children}</h1>
       <button type="button" onClick={() => setCount((count) => count + 1)}>
         Count: {count}
diff --git a/template/framework/preact/src/entries/contentScript/primary/App.jsx b/template/framework/preact/src/entries/contentScript/primary/App.jsx
@@ -6,7 +6,7 @@ function App() {
 
   return (
     <div class="logo">
-      <img src={logoImageUrl} height="50" />
+      <img src={logoImageUrl} height="50" alt="" />
     </div>
   );
 }
diff --git a/template/framework/react-ts/src/components/PageContent.tsx b/template/framework/react-ts/src/components/PageContent.tsx
@@ -9,7 +9,7 @@ function PageContent(props) {
 
   return (
     <div>
-      <img src={imageUrl} height="45" />
+      <img src={imageUrl} height="45" alt="" />
       <h1>{props.children}</h1>
       <button type="button" onClick={() => setCount((count) => count + 1)}>
         Count: {count}
diff --git a/template/framework/react-ts/src/entries/contentScript/primary/App.tsx b/template/framework/react-ts/src/entries/contentScript/primary/App.tsx
@@ -6,7 +6,7 @@ function App() {
 
   return (
     <div class="logo">
-      <img src={logoImageUrl} height="50" />
+      <img src={logoImageUrl} height="50" alt="" />
     </div>
   );
 }
diff --git a/template/framework/react/src/components/PageContent.jsx b/template/framework/react/src/components/PageContent.jsx
@@ -9,7 +9,7 @@ function PageContent(props) {
 
   return (
     <div>
-      <img src={imageUrl} height="45" />
+      <img src={imageUrl} height="45" alt="" />
       <h1>{props.children}</h1>
       <button type="button" onClick={() => setCount((count) => count + 1)}>
         Count: {count}
diff --git a/template/framework/react/src/entries/contentScript/primary/App.jsx b/template/framework/react/src/entries/contentScript/primary/App.jsx
@@ -6,7 +6,7 @@ function App() {
 
   return (
     <div class="logo">
-      <img src={logoImageUrl} height="50" />
+      <img src={logoImageUrl} height="50" alt="" />
     </div>
   );
 }
diff --git a/template/framework/svelte-ts/src/entries/contentScript/primary/App.svelte b/template/framework/svelte-ts/src/entries/contentScript/primary/App.svelte
@@ -5,7 +5,7 @@
 </script>
 
 <div class="logo">
-  <img src={logoImageUrl} height="50" />
+  <img src={logoImageUrl} height="50" alt="" />
 </div>
 
 <style>
diff --git a/template/framework/svelte-ts/src/lib/PageContent.svelte b/template/framework/svelte-ts/src/lib/PageContent.svelte
@@ -9,7 +9,7 @@
   }
 </script>
 
-<img src={imageUrl} height="45" />
+<img src={imageUrl} height="45" alt="" />
 <h1>
   <slot></slot>
 </h1>
diff --git a/template/framework/svelte/src/entries/contentScript/primary/App.svelte b/template/framework/svelte/src/entries/contentScript/primary/App.svelte
@@ -5,7 +5,7 @@
 </script>
 
 <div class="logo">
-  <img src={logoImageUrl} height="50" />
+  <img src={logoImageUrl} height="50" alt="" />
 </div>
 
 <style>
diff --git a/template/framework/svelte/src/lib/PageContent.svelte b/template/framework/svelte/src/lib/PageContent.svelte
@@ -9,7 +9,7 @@
   }
 </script>
 
-<img src={imageUrl} height="45" />
+<img src={imageUrl} height="45" alt="" />
 <h1>
   <slot></slot>
 </h1>
diff --git a/template/framework/vanilla-ts/src/entries/contentScript/primary/main.ts b/template/framework/vanilla-ts/src/entries/contentScript/primary/main.ts
@@ -9,7 +9,7 @@ renderContent(
 
     appRoot.innerHTML = `
     <div class="logo">
-      <img src="${logoImageUrl}" height="50" />
+      <img src="${logoImageUrl}" height="50" alt="" />
     </div>
   `;
   }
diff --git a/template/framework/vanilla-ts/src/entries/options/main.ts b/template/framework/vanilla-ts/src/entries/options/main.ts
@@ -4,7 +4,7 @@ import "./style.css";
 const imageUrl = new URL(logo, import.meta.url).href;
 
 document.querySelector("#app")!.innerHTML = `
-  <img src="${imageUrl}" height="45" />
+  <img src="${imageUrl}" height="45" alt="" />
   <h1>Options</h1>
   <a href="https://vitejs.dev/guide/features.html" target="_blank">Vite Docs</a>
 `;
diff --git a/template/framework/vanilla-ts/src/entries/popup/main.ts b/template/framework/vanilla-ts/src/entries/popup/main.ts
@@ -4,7 +4,7 @@ import "./style.css";
 const imageUrl = new URL(logo, import.meta.url).href;
 
 document.querySelector("#app")!.innerHTML = `
-  <img src="${imageUrl}" height="45" />
+  <img src="${imageUrl}" height="45" alt="" />
   <h1>Popup</h1>
   <a href="https://vitejs.dev/guide/features.html" target="_blank">Vite Docs</a>
 `;
diff --git a/template/framework/vanilla/src/entries/contentScript/primary/main.js b/template/framework/vanilla/src/entries/contentScript/primary/main.js
@@ -7,7 +7,7 @@ renderContent(import.meta.CURRENT_CONTENT_SCRIPT_CSS_URL, (appRoot) => {
 
   appRoot.innerHTML = `
     <div class="logo">
-      <img src="${logoImageUrl}" height="50" />
+      <img src="${logoImageUrl}" height="50" alt="" />
     </div>
   `;
 });
diff --git a/template/framework/vanilla/src/entries/options/main.js b/template/framework/vanilla/src/entries/options/main.js
@@ -4,7 +4,7 @@ import "./style.css";
 const imageUrl = new URL(logo, import.meta.url).href;
 
 document.querySelector("#app").innerHTML = `
-  <img src="${imageUrl}" height="45" />
+  <img src="${imageUrl}" height="45" alt="" />
   <h1>Options</h1>
   <a href="https://vitejs.dev/guide/features.html" target="_blank">Vite Docs</a>
 `;
diff --git a/template/framework/vanilla/src/entries/popup/main.js b/template/framework/vanilla/src/entries/popup/main.js
@@ -4,7 +4,7 @@ import "./style.css";
 const imageUrl = new URL(logo, import.meta.url).href;
 
 document.querySelector("#app").innerHTML = `
-  <img src="${imageUrl}" height="45" />
+  <img src="${imageUrl}" height="45" alt="" />
   <h1>Popup</h1>
   <a href="https://vitejs.dev/guide/features.html" target="_blank">Vite Docs</a>
 `;
diff --git a/template/framework/vue-ts/src/components/PageContent.vue b/template/framework/vue-ts/src/components/PageContent.vue
@@ -1,5 +1,5 @@
 <template>
-  <img :src="imageUrl" height="45" />
+  <img :src="imageUrl" height="45" alt="" />
   <h1>
     <slot></slot>
   </h1>
diff --git a/template/framework/vue-ts/src/entries/contentScript/primary/App.vue b/template/framework/vue-ts/src/entries/contentScript/primary/App.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="logo">
-    <img :src="logoImageUrl" height="50" />
+    <img :src="logoImageUrl" height="50" alt="" />
   </div>
 </template>
 
diff --git a/template/framework/vue/src/components/PageContent.vue b/template/framework/vue/src/components/PageContent.vue
@@ -1,5 +1,5 @@
 <template>
-  <img :src="imageUrl" height="45" />
+  <img :src="imageUrl" height="45" alt="" />
   <h1>
     <slot></slot>
   </h1>
diff --git a/template/framework/vue/src/entries/contentScript/primary/App.vue b/template/framework/vue/src/entries/contentScript/primary/App.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="logo">
-    <img :src="logoImageUrl" height="50" />
+    <img :src="logoImageUrl" height="50" alt="" />
   </div>
 </template>
 

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ function App() {`
`6`	`6`
`7`	`7`	`return (`
`8`	`8`	`<div class="logo">`
`9`		`- <img src={logoImageUrl} height="50" />`
	`9`	`+ <img src={logoImageUrl} height="50" alt="" />`
`10`	`10`	`</div>`
`11`	`11`	`);`
`12`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`}`
`10`	`10`	`</script>`
`11`	`11`
`12`		`-<img src={imageUrl} height="45" />`
	`12`	`+<img src={imageUrl} height="45" alt="" />`
`13`	`13`	`<h1>`
`14`	`14`	`<slot></slot>`
`15`	`15`	`</h1>`