Includes improvement #121
Closed
Includes improvement #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `set_line` function now returns an int rather than a bool. Values are 0 for success, 1 for invalid line and 2 for invalid coloumn, as well as -1 for an internal error. * You can no longer go beyond the maximum coloumn in form input. For example if the input has 50 characters in length, you can go up to 51, because 51 will be the blank character from which you can continue to write from the end. This change closes samtupy#62. * Improved the touch.nvgt `is_available` method's return value as `return dev.length() > 0;` for short.
|
this was already that case, please don't do this. int max_col = text.lenght+1 |
|
@amirmahdifard You yourself asked to do that in issue #62 I believe. The column will only able to type 1 length beyond its text. For example text with 18 characters you could type 19 to get to the blank character, and 20 will fail. I have personally tested. |
|
yes I asked, but please return this line back because this will work that way better because it will only effect the current line, and as i'm testing, this also works as we expect, so return this back, like this like befor. |
|
@amirmahdifard Do you mean not to change it? Not to print error message? Ok then. This fixes by closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_linefunction now returns an int rather than a bool. Values are 0 for success, 1 for invalid line and 2 for invalid coloumn, as well as -1 for an internal error.is_availablemethod's return value asreturn dev.length() > 0;for short.