Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no _dump_data is defined for class Thread::Mutex #1378

Open
jcoyne opened this issue Jan 24, 2019 · 3 comments
Open

no _dump_data is defined for class Thread::Mutex #1378

jcoyne opened this issue Jan 24, 2019 · 3 comments

Comments

@jcoyne
Copy link
Member

jcoyne commented Jan 24, 2019

     Failure/Error: marshalled = Marshal.dump(post)
     
     TypeError:
       no _dump_data is defined for class Thread::Mutex
     # ./spec/integration/marshal_spec.rb:23:in `dump'
     # ./spec/integration/marshal_spec.rb:23:in `block (3 levels) in <top (required)>'

This started occuring around Nov 7, 2018. Is it possible this is correlated with ActiveTriples 1.1.0?

passing: https://travis-ci.org/samvera/active_fedora/builds/449013449
failed: https://travis-ci.org/samvera/active_fedora/builds/452041167

@jcoyne
Copy link
Member Author

jcoyne commented Jan 24, 2019

diff:

< Fetching concurrent-ruby 1.1.0
> Fetching concurrent-ruby 1.1.3

< Using rack 1.6.10
> Fetching rack 1.6.11

< Using tins 1.17.0
> Fetching tins 1.19.0


> Fetching rdf 3.0.6
< Using rdf 3.0.5

@jcoyne
Copy link
Member Author

jcoyne commented Jan 24, 2019

Rdf 3.0.6 was released in that timeframe and added a Mutex: https://github.com/ruby-rdf/rdf/releases/tag/3.0.6

@cjcolvar
Copy link
Member

I reverted to rdf 3.0.5 and the failing tests passed. I think we should pin to rdf 3.0.5 for now and fix this in rdf by implementing marshal_dump and marshal_load. I'm working on a PR to rdf now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Status: Backlog
Development

No branches or pull requests

2 participants