Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"For Contributors" document is out-of-date #326

Open
2 tasks
mark-dce opened this issue Mar 8, 2016 · 2 comments
Open
2 tasks

"For Contributors" document is out-of-date #326

mark-dce opened this issue Mar 8, 2016 · 2 comments

Comments

@mark-dce
Copy link

mark-dce commented Mar 8, 2016

STORY
As a new hydra dev, I would like to run the test suite, so that I can contribute via PRs.

DETAILS
When I read the Modifying and Testing the hydra-head Gem section of the README, it links me to the Instructions for Contributors page on the wiki. The instruction there reference hydra-jetty, etc.

When I try to run rake ci after following those instructions, I get a stack dump:

$ rake ci
rake aborted!
LoadError: cannot load such file -- solr_wrapper
/Users/mark/Documents/workspace/_no_backup/RubymineProjects/hydra-head/Rakefile:6:in `<top (required)>'
(See full trace by running task with --trace)

ACCEPTANCE
EITHER

  • delete the wiki page and update the reference in the README to just point at CONTRIBUTING.md. In which case, I don't really get information on how to run the tests.
    OR
  • update the wiki page to reflect current practice so I can follow the instructions successfully.
@mark-dce
Copy link
Author

mark-dce commented May 6, 2016

I've made updates to the "for the impatient" section. The following sections still need to be re-written to explain how to test using engine cart in more detail - i.e. how to setup to run individual tests.

@jcoyne
Copy link
Member

jcoyne commented May 6, 2016

Super!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

4 participants