Contact form fails due to negative captcha changes

[gleithner]

Descriptive summary

ghcr.io/samvera/hyku:5.0.0

While testing the contact form in our lab, it was throwing an error about missing parameters despite all fields being filled out: "Sorry, this message was not sent successfully. Email can't be blank, Name can't be blank, Subject can't be blank, Message can't be blankNo params provided"

Rationale

When I compared it to the Palni-Palci code, I found that the negative captcha code is missing the updated view that Palni-Palci has, although it is found here in spec/views/hyrax/contact_form/new.html.erb (except the subject field is not tagged correctly). I copied the code from the spec/views/hyrax/contact_form/new.html.erb to app/views/hyrax/contact_form/, and then updated the subject field to match the tagging of the other fields. After that, the contact form submission works correctly.

I'm not quite confident enough in my Rails knowledge to know if this is an appropriately complete solution, so I'm posting here as an Issue for consideration.

Related work

#1877