Make awareness a map #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'll try to make sure this gets a review. I looked quickly, and I'm not sure we would want to remove |
|
FYI I moved to a different architecture where I no longer need this. I don't mind finishing this anyway but I want to make sure you don't feel any need to rush the review. Also feel free to close this if you're uninterested in the change. |
|
Thanks, Daniel. It seems we don't have the time to take a look at this right now, but I think this is a change for the better so I'll keep the PR open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49 and #45.
To simplify, I didn't implement syncing remote changes to the local client's awareness state. I don't think that's common or useful. If I'm wrong, I can add that.