Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TTML writer should not output cell units #336

Open
palemieux opened this issue Oct 8, 2021 · 1 comment · May be fixed by #382
Open

TTML writer should not output cell units #336

palemieux opened this issue Oct 8, 2021 · 1 comment · May be fixed by #382
Assignees
@palemieux
Labels
c-imsc-writer enhancement New feature or request
Milestone
1.1.1

Comments

@palemieux
Copy link
Contributor

palemieux commented Oct 8, 2021 •
edited
Loading

In IMSC, "c" units are only permitted on the ebutts:linePadding property.

Instead TTML writer should allow the user to specify that rh and rw units are used.
@palemieux palemieux added this to the 1.0.5 milestone Oct 14, 2021
@palemieux palemieux added enhancement New feature or request c-imsc-writer labels Dec 12, 2021
@palemieux palemieux modified the milestones: 1.0.5, 1.0.6 Apr 2, 2022
@palemieux palemieux modified the milestones: 1.0.6, 1.0.7 Jan 4, 2023
@palemieux
Copy link
Contributor Author

rh and rw units cannot replace c units directly since the value of c depends on whether c is evaluated in a horizontal or vertical context. In the case of padding, for example, this cannot be determine without determining the computed value of tts:writingMode, which itself requires determining the region with which the element is associated.

It might therefore make more sense to limit the model such that only c units can be used with ebutts:linePadding, i.e. enforcing the IMSC model.

@palemieux palemieux self-assigned this Jan 14, 2023
@palemieux palemieux linked a pull request Jan 16, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palemieux palemieux

Labels
c-imsc-writer enhancement New feature or request
Projects
None yet
Milestone
1.1.1
Development

Successfully merging a pull request may close this issue.

Disallow 'c' units for all style properties with the exception of ebutts:linePadding sandflow/ttconv
1 participant
@palemieux