Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trilinos/Albany rpath to export_albany #1005

Open
jewatkins opened this issue Nov 3, 2023 · 5 comments
Open

Add Trilinos/Albany rpath to export_albany #1005

jewatkins opened this issue Nov 3, 2023 · 5 comments

Comments

@jewatkins
Copy link
Collaborator

When I build MALI, I usually add this to avoid having to add albany/trilinos to my system library search path at runtime:

MPAS_EXTERNAL_LIBS="${ALBANY_LINK_LIBS} -Wl,-R${ALBANY_INSTALL}/lib64 -Wl,-R${TRILINOS_INSTALL}/lib64"

Does it make sense to just add it as part of export_albany.in?

@mperego @bartgol I'm not extremely familiar with how cmake generates this file anymore with all the changes so not sure how we would do it. I don't think this is urgent, more a QOL change.

@bartgol
Copy link
Collaborator

bartgol commented Nov 3, 2023

I thought we were linking all libraries via full system path, so there shouldn't be any need for adding path to the link line. Are you dating you get immediate references at Link time or ld run-time lead errors?

@mperego
Copy link
Collaborator

mperego commented Nov 3, 2023

I think @jewatkins is talking about run-time errors. I'm in favor of adding that to the export_albany.in or anyway for a solution that does not require to explicitly export Trilinos and albnay libraries in the LD_LIBRARY_PATH.

@jewatkins
Copy link
Collaborator Author

right runtime errors

@jewatkins
Copy link
Collaborator Author

My understanding is that -rpath or -R adds the path to the executable (in this case, MALI) for the runtime linker.

@bartgol
Copy link
Collaborator

bartgol commented Nov 4, 2023

Ok. Adding to export_albany.in is fine then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants