You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since we're in a reorg/cleanup mood, I would do the following:
Albany_config.h: keep Albany-wide options
Albany_packages.h: put the list of packages-enabling macros (e.g., ALBANY_LANDICE)
LandIce_config.h: put the configs for LandIce (e.g., CISM_HAS_LANDICE)
We could also consider adding packages macros with target_compile_definitions, and do away with Albany_packages.h. LandIce also has very few options (for now), which could prob just be added via target_compile_definitions as well. Splitting some options out of Albany_config.h would also allow to move some cmake logic in our main CMakeLists.txt into LandIce/CMakeLists.txt, which is more appropriate.
Whatever approach we choose (multiple config.h files, vs target_compile_definitions), I would like Albany to not fully rebuild if we toggle, say, ALBANY_ENABLE_DEMO_PDES.
The text was updated successfully, but these errors were encountered:
Since we're in a reorg/cleanup mood, I would do the following:
We could also consider adding packages macros with
target_compile_definitions
, and do away withAlbany_packages.h
. LandIce also has very few options (for now), which could prob just be added viatarget_compile_definitions
as well. Splitting some options out ofAlbany_config.h
would also allow to move some cmake logic in our main CMakeLists.txt intoLandIce/CMakeLists.txt
, which is more appropriate.Whatever approach we choose (multiple config.h files, vs
target_compile_definitions
), I would like Albany to not fully rebuild if we toggle, say,ALBANY_ENABLE_DEMO_PDES
.The text was updated successfully, but these errors were encountered: