Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inclined contact tests #60

Closed
lxmota opened this issue Feb 19, 2025 · 0 comments · Fixed by #61
Closed

Fix inclined contact tests #60

lxmota opened this issue Feb 19, 2025 · 0 comments · Fixed by #61
Assignees
@brianphung

Comments

@lxmota
Copy link
Collaborator

lxmota commented Feb 19, 2025

The fix 8e124e8 for an error in the computation of stops for time stepping broke the inclined contact tests. Most likely because the times at which the solutions are compared are now out of sync. I disabled these test for now to continue to fox other related issues. Please help fix @brianphung and sorry for the mess.
@brianphung brianphung mentioned this issue Feb 19, 2025
Merged
@brianphung brianphung linked a pull request Feb 19, 2025 that will close this issue
Inclined contact test fix #61
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianphung brianphung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inclined contact test fix brianphung/Norma.jl
2 participants
@lxmota @brianphung