Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distribution_info broken for map layouts #492

Open
coreyostrove opened this issue Sep 27, 2024 · 0 comments
Open

distribution_info broken for map layouts #492

coreyostrove opened this issue Sep 27, 2024 · 0 comments
Labels
bug A bug or regression low priority Developers should be aware of this issue, but it need not be addressed imminently
Milestone

Comments

@coreyostrove
Copy link
Contributor

Jotting down some details on a low-priority bug for future reference.

When calling the distribution_info method of the DistributableCOPALayout class, which is a parent class to MapCOPALayout this results in the following exception.

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[7], line 1
----> 1 test_layout_2Q_size_prop.distribution_info(1)

File ~\Documents\pyGSTi_API_updates\pygsti\layouts\distlayout.py:1381, in DistributableCOPALayout.distribution_info(self, nprocs)
   1378 info = {}
   1379 subcomm_ranks = _collections.defaultdict(list)
-> 1381 nAtomComms = self.num_atom_processing_subcomms
   1382 nAtoms = len(self.atoms)
   1383 assert(nAtomComms <= nAtoms), "Cannot request more sub-comms ({nAtomComms}) than there are atoms ({nAtoms})!"

AttributeError: 'MapCOPALayout' object has no attribute 'num_atom_processing_subcomms'

The only references to this attribute I can find with a search of the codebase are in this method, so presumably this is referring to an attribute that was either renamed or removed. We should fix this at some indeterminate point in the future (or else decide to remove the broken method if it isn't an easy fix).

@coreyostrove coreyostrove added bug A bug or regression low priority Developers should be aware of this issue, but it need not be addressed imminently labels Sep 27, 2024
@sserita sserita added this to the 0.9.14 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug or regression low priority Developers should be aware of this issue, but it need not be addressed imminently
Projects
None yet
Development

No branches or pull requests

2 participants