Named middleware doesn't work

[atticusfyj]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

Middlewares registered with app.register_named_middleware don't seem to work.

Code snippet

# playground.py
from sanic import Sanic, text

app = Sanic("my-app")

@app.get("/test", name="test")
def test(request):
    return text("This is response")

async def middleware(request):
    print("This is middleware")

app.register_named_middleware(middleware, ["test"])

Expected Behavior

Running sanic playground:app --host=0.0.0.0 --port=8000 --workers=1 and initiate a GET to 0.0.0.0:8000 is expected to emit a print in console.

How do you run Sanic?

Sanic CLI

Operating System

MacOS

Sanic Version

24.6.0

Additional context

No response

[cosmastech]

I think you need to add @app.on_request to your middleware function.

@app.on_request
async def middleware(request):
    print("This is middleware")

[ahopkins]

You need to use the full route name:

app.register_named_middleware(middleware, ["my-app.test"])

For reference, this is how Blueprint-based middleware works.