You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current logic for the "Import" button is that it's disabled when progress is less than 1.
However, the CSS in the ProgressBar component expects 0 ≥ progress ≤ 100 as it divides that number by 100 to get a decimal value for rendering the bar. For example, given that CSS and progress equal to 1 then it will correctly render the progress bar as completely filled.
As a result of this mismatch the "Import" button is not disabled when progress !== 1
Actual
Expected
The text was updated successfully, but these errors were encountered:
matthewborgman
added a commit
to matthewborgman/sanity-translations-tab
that referenced
this issue
Jan 17, 2023
Thanks for reporting, Matthew! In this case, I think being able to import partial translations was intended behavior. But I agree that it certainly makes sense to disallow that behavior.
Does it make sense to hoist a boolean to the config, something like allowPartialImports (or a better variable name) that defaults to true but can be overridden and have this behavior?
This would also stop this from being a breaking change and major version update.
The current logic for the "Import" button is that it's disabled when
progress
is less than 1.However, the CSS in the
ProgressBar
component expects 0 ≥progress
≤ 100 as it divides that number by 100 to get a decimal value for rendering the bar. For example, given that CSS andprogress
equal to 1 then it will correctly render the progress bar as completely filled.As a result of this mismatch the "Import" button is not disabled when
progress
!== 1Actual
Expected
The text was updated successfully, but these errors were encountered: