From 3da8a9a182da28be213a99ecc3b377ac27fdffcb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B8rge=20N=C3=A6ss?= <bjoerge@gmail.com>
Date: Tue, 24 Sep 2024 14:31:00 +0200
Subject: [PATCH] fix: return undefined as machine id if it can't be determined

---
 packages/@sanity/cli/src/cli.ts   | 5 ++---
 packages/@sanity/cli/src/types.ts | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/packages/@sanity/cli/src/cli.ts b/packages/@sanity/cli/src/cli.ts
index 8424115f04c..2f4dcce0e61 100755
--- a/packages/@sanity/cli/src/cli.ts
+++ b/packages/@sanity/cli/src/cli.ts
@@ -44,9 +44,8 @@ function installProcessExitHack(finalTask: () => Promise<unknown>) {
 async function getDeviceId() {
   try {
     return await machineId()
-  } catch(error) {
-    console.error('Failed to get device ID:', error)
-    return 'unknown device id'
+  } catch (error) {
+    return undefined
   }
 }
 
diff --git a/packages/@sanity/cli/src/types.ts b/packages/@sanity/cli/src/types.ts
index ac85b2d5666..503b1fdc69e 100644
--- a/packages/@sanity/cli/src/types.ts
+++ b/packages/@sanity/cli/src/types.ts
@@ -94,7 +94,7 @@ export interface CliBaseCommandContext {
 }
 
 export interface TelemetryUserProperties {
-  deviceId: string
+  deviceId: string | undefined
   runtime: string
   runtimeVersion: string
   cliVersion: string