From 8ca1c0dbed97b415e648fd3dcd8bb5f05cef90df Mon Sep 17 00:00:00 2001 From: Rico Kahler Date: Thu, 18 Jul 2024 19:31:40 -0500 Subject: [PATCH] docs: add TODO comment about improving test --- .../src/_internal/cli/server/__tests__/aliases.test.ts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/packages/sanity/src/_internal/cli/server/__tests__/aliases.test.ts b/packages/sanity/src/_internal/cli/server/__tests__/aliases.test.ts index def49d4ad60..f4a1af19cb5 100644 --- a/packages/sanity/src/_internal/cli/server/__tests__/aliases.test.ts +++ b/packages/sanity/src/_internal/cli/server/__tests__/aliases.test.ts @@ -47,6 +47,15 @@ describe('browserCompatibleSanityPackageSpecifiers', () => { }) describe('getAliases', () => { + // TODO: this test would be better if it called `vite.build` with fixtures + // but vite does not seem to be compatible in our jest environment. + // Error from trying to import vite: + // + // > Invariant violation: "new TextEncoder().encode("") instanceof Uint8Array" is incorrectly false + // > + // > This indicates that your JavaScript environment is broken. You cannot use + // > esbuild in this environment because esbuild relies on this invariant. This + // > is not a problem with esbuild. You need to fix your environment instead. it('returns the correct aliases for normal builds', () => { const aliases = getAliases({ sanityPkgPath,