Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mario RPG SA-1 HiRom issue #781

Closed
Slyazku opened this issue Apr 27, 2023 · 4 comments
Closed

Mario RPG SA-1 HiRom issue #781

Slyazku opened this issue Apr 27, 2023 · 4 comments

Comments

@Slyazku
Copy link

Slyazku commented Apr 27, 2023

Well I have this bad identification of Super Mario RPG, it should be Lowrom. Dump works but CRC fails and I can't read rom file in an emulator.
I use HWrev 5 and tried 2 diferent boards of SNES Cic and 2 different clock generators, one working perfectly on HW rev3
IMG_20230427_232342

@sanni
Copy link
Owner

sanni commented May 4, 2023

The OSCR dumps SA1 as if it was HiROM.

That being said, SA1 code is still far from perfect. One thing you can try is to lower the clocks.
A real SNES seems to run at only 5.3MHz for EXT and 2.6MHz for CPU clock when reading SA1:

sa1clocks

Change line 484

 if (i2c_found) {
    //Set clocks to standard or else SA-1 sram writing will fail
    clockgen.set_freq(2147727200ULL, SI5351_CLK0);
    clockgen.set_freq(357954500ULL, SI5351_CLK1);
    clockgen.set_freq(307200000ULL, SI5351_CLK2);
  }

to:

  if (i2c_found) {
    //Set clocks to standard or else SA-1 sram writing will fail
    clockgen.set_freq(536931800ULL, SI5351_CLK0);
    clockgen.set_freq(268465900ULL, SI5351_CLK1);
    clockgen.set_freq(307200000ULL, SI5351_CLK2);
  } 

Maybe it helps.

Also make sure you got Rev3 of the Six Slot Adapter or apply the fix for Rev1/Rev2.

@Slyazku
Copy link
Author

Slyazku commented Jun 25, 2023

Sorry for the late answer. Just wanted to let know the fix works perfectly, I can dump the Rom despite the CRC32 Error - Error Database Missing.
Thanks !

@sanni
Copy link
Owner

sanni commented Jun 26, 2023

Which fix you mean the hardware fix for Rev1/Rev2 or do you mean changing the code like shown above?

@sanni
Copy link
Owner

sanni commented Jun 26, 2023

Duplicate of #734

@sanni sanni marked this as a duplicate of #734 Jun 26, 2023
@sanni sanni closed this as completed Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants