Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Power League 4 Being Overdumped #875

Open
breyell opened this issue Dec 7, 2023 · 2 comments
Open

Super Power League 4 Being Overdumped #875

breyell opened this issue Dec 7, 2023 · 2 comments

Comments

@breyell
Copy link
Contributor

breyell commented Dec 7, 2023

OSCR firmware version

13.1

OSCR hardware version

HW5 Rev5

Attach OSCR_LOG.txt file here

No response

System used

SNES/Super Famicom

Describe the issue.

Super Power League 4 is dumping 3MB files when they should only be 2MB. The first 2MB is great and exactly as expected.

Worth noting Super Power League is one of 3 SPC7110 games. I also have Tengai Makyō Zero (Far East of Eden Zero) and was able to confirm that dumps fine. I also noticed there's a note for the other (Momotarou Dentetsu Happy) in the code so I assume that one works fine as well but I don't have a cart to verify. Also worth noting Super Power League 4 is the smallest of the 3 roms.

@sanni
Copy link
Owner

sanni commented Dec 7, 2023

In SNES.ino line 1035-1037 SPC HiROM games get set to 3MB. This is aimed at fixing Momotarou Dentetsu Happy but also seems to wrongly affect Super Power League 4.

} else if ((romChips == 245) && (romType == HI)) {
    romSize = 24;
    numBanks = 48;

There is a similar fix for Tengai Makyou Zero in line 1038-1040.

  } else if ((romChips == 249) && (romType == HI)) {
    romSize = 40;
    numBanks = 80;

The corresponding entries in the snes.txt database are currently ignored because of the above fixes.

snes.txt format:

Name
CRC32, internal checksum, CRC32 of header area(0xFFB0-0xFFFF), size in Mbit, number of banks

snes.txt line 5482

Momotarou Dentetsu Happy (Japan).sfc
0B8D1474,5DD6,3FBA1E71,24,096

snes.txt line 9598

Super Power League 4 (Japan).sfc 
C07F099D,0920,4FA7DF0E,02,004

snes.txt line 10336

Tengai Makyou Zero (Japan).sfc 
1E327BD9,B704,ED793884,40,080

And at least for Super Power League 4 the size info in snes.txt seems to be wrong too, should be 16 Mbit and 32 banks not 2 Mbit and 4 banks. Also I am not sure about the internal checksums, as they differ from what an emulator reports.

To start fixing this issue line 1035 to 1040 should be (temporarily) deleted from SNES.ino and then the three games should be retested to see what internal checksum they are searching the database for and if the checksum is always the same or random on multiple tries.

If the checksum is always the same we can use the snes.txt database to set the ROM sizes.
And if the reported checksum is random then line 1035 to 1040 need to be put back into snes.ino and an additional entry for Super Power League 4 needs to be created.

@VamPikmin
Copy link

VamPikmin commented Dec 15, 2024

Momotarou Dentetsu Happy dumps fine for me
Same problem with Super Power League 4, after cleaning it thoroughly it always (over)dumps with the same checksum

OSCR HW5 V14.3

[+] Super Nintendo/SFC

[+] SNES/SFC cartridge


Searching database...
Checksum: E28C

Name: MOMOTETSU HAPPY
Revision: 0
Type: HiROM FastROM
ICs: ROM SPC RAM BATT
ROM Size: 3 MB (48 banks)
Save Size: 8 KB
Checksum: E28C
Press Button...

[+] Read ROM


Saving to SNES/ROM/MOMOTETSU HAPPY/57/...
Dumping SPC7110 HiRom
[*******************]
[*******************]

Checksum... E28C -> OK
CRC32... 0B8D1474 -> Momotarou Dentetsu Happy (Japan).sfc`
OSCR HW5 V14.3

[+] Super Nintendo/SFC

[+] SNES/SFC cartridge


Searching database...
Checksum: 01AA

Name: SUPER POWER LEAG 4
Revision: 0
Type: HiROM FastROM
ICs: ROM SPC RAM BATT
ROM Size: 3 MB (48 banks)
Save Size: 8 KB
Checksum: 01AA
Press Button...

[+] Read ROM


Saving to SNES/ROM/SUPER POWER LEAG 4/64/...
Dumping SPC7110 HiRom
[*******************]
[*******************]

Checksum... 6836 != 01AA
Invalid Checksum
CRC32... 7CAB0DF3 -> Not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants