sap_install_media_detect: sap_export_nwas_java detection

[remrozk]

Ansible Role

sap_install_media_detect

OS Family

N/A

Ansible Controller - Python version

python --version
Python 3.11.13

Ansible-core version

ansible --version
ansible [core 2.16.14]

Bug Description

Issue

The sapfile Bash script was updated in the commit 63f1e74. However, since the exit; statement was removed from the sap_export_nwas_java detection block, the detection logic for S/4HANA Java files (sap_export_nwas_java) is no longer properly handled.

Problem

The Bash script continues processing past the sap_export_nwas_java detection and ends up matching the regular expression /EXP[0-9]/, which is intended for identifying sap_export_ecc_ides files. This results in an incorrect match, where sap_export_ecc_ides logic is applied to files related to S/4HANA Java, like in the following example:

zipinfo -1 51057035.ZIP | awk '/EXP[0-9]/'
DATA_UNITS/EHS_EXPERT_SERVER/EHSEXP32_59.EXE

Solution

To resolve this, I propose updating the awk regex /EXP[0-9]/ to be more restrictive and prevent it from matching unintended cases. Specifically, the regex should be modified to differentiate between sap_export_ecc_ides and sap_export_nwas_java more accurately.

Bug reproduction

1. Download the DATA_UNITS for SAP S/4HANA JAVA (Software Center > INSTALLATIONS & UPGRADES > By Alphabetical Index (A-Z) > S > SAP S/4HANA > choose the version > INSTALLATION AND UPGRADE > 5XXXXX.ZIP)
2. Run the command zipinfo -1 5XXXXX.ZIP | awk '/EXP[0-9]/'

Community participation

Happy to implement this bug fix

[berndfinger]

The PR which contains the commit 63f1e74 is #913.
The related issue is #912, not 921 as mentioned in the commit 63f1e74.

[berndfinger]

With commit berndfinger@1783b9b, the result of sapfile with various possibly affected files is now:

$ sapfile *
51054655_3.zip:                          sap_export_solman_lang  
51057035:                                sap_export_nwas_java    
HDB_LSS_2_048_6-80004532.SAR:            saphana_other           
igsexe_4-70005417.sar:                   sap_igs                 
igshelper_17-10010245.sar:               sap_igs                 
IMDB_CLIENT20_022_32-80002082.SAR:       saphana_client          
IMDB_SERVER20_085_0-80002031.SAR:        saphana                 
NW 7.5 Installation Export:              sap_export_nwas_abap    
S4FND108_INST_EXPORT_1.zip:              sap_export_s4hana       
S4FND108_INST_EXPORT_2.zip:              sap_export_s4hana       
[...]
S4FND108_INST_EXPORT_8.zip:              sap_export_s4hana       
S4FND108_INST_EXPORT_9.zip:              sap_export_s4hana       
S4FND108_NW_LANG_DE.SAR:                 sap_s4hana_lang         
S4FND108_NW_LANG_EN.SAR:                 sap_s4hana_lang         
SAPCAR_1400-70007716.EXE:                sapcar                  
SAPEXE_60-70007807.SAR:                  sap_kernel              
SAPEXEDB_60-70007806.SAR:                sap_kernel_db_hdb       
SAPHOSTAGENT67_67-80004822.SAR:          sap_hostagent           
SAP Netweaver 7.5 SP22 Java:             sap_export_nwas_java    
SAP Solution Manager 7.2 SR2 Installation Export I: sap_export_solman_abap  
SAP Solution Manager 7.2 SR2 Installation Export II: sap_export_solman_abap  
SAP Solution Manager 7.2 SR2 - Java:     sap_export_solman_java  
SAP Solution Manager 7.2 SR2 Language:   sap_export_solman_lang  
SWPM20SP21_0-80003424.SAR:               sap_swpm

[sean-freeman]

@berndfinger You may want to perform a wide-scope test, using https://github.com/sap-linuxlab/ansible.playbooks_for_sap/tree/main/special_actions/sap_download_install_media

[berndfinger]

Hi @remrozk,

To resolve this, I propose updating the awk regex /EXP[0-9]/ to be more restrictive and prevent it from matching unintended cases. Specifically, the regex should be modified to differentiate between sap_export_ecc_ides and sap_export_nwas_java more accurately.

The problem is that in this case (same as for distinguishing sap_export_nwas_abap from sap_export_solman_abap, see https://github.com/sap-linuxlab/community.sap_install/blob/dev/roles/sap_install_media_detect/files/tmp/sapfile#L297..L302), looking at the list of files is not sufficient - or I have not yet identified unique patterns).

So I searched for a unique pattern in some of the files and found that the file DATA_UNITS/LABELIDX.ASC in the file SAP Solution Manager 7.2 SR2 - Java contains a line which starts with SOLMANand contains the string _JAVA, which the file SAP Netweaver 7.5 SP22 Java does not have.

Before raising a PR with berndfinger@1783b9b, I would like to run more tests (as also suggested by @sean-freeman above). Due to time constraints and higher prioritized projects, I expect to be able to run these tests only in a few weeks.

If anyone finds a unique pattern in the zipinfo -l output, I am happy to use that pattern instead of extracting a file and checking its content.

[remrozk]

Hi @berndfinger,

After conducting an investigation, I have identified a potential solution to detect the archive and assign it to the correct targeted installation.

For Java systems, the file DATA_UNITS/JAVA_EXPORT/LABEL.ASC contains global information, such as whether it is a NetWeaver 7.50 system or an S/4HANA system with its specific version.

SAP-NETWEAVER-750-JAVA $ unzip -p 51055106.ZIP DATA_UNITS/JAVA_EXPORT/LABEL.ASC
SAP:JEXPORT:750:SP22:*:*

SAP-S4-2021-JAVA $ unzip -p 51055031.ZIP DATA_UNITS/JAVA_EXPORT/LABEL.ASC
SAP:JEXPORT:2021S4_756:*:*:*

SAP-S4-2022-JAVA $ unzip -p 51055643.ZIP DATA_UNITS/JAVA_EXPORT/LABEL.ASC
SAP:JEXPORT:2022S4_757:*:*:*

SAP-S4-2023-JAVA $ unzip -p 51057035.ZIP DATA_UNITS/JAVA_EXPORT/LABEL.ASC
SAP:JEXPORT:2023S4_758:*:*:*

Additionally, for SAP Solution Manager, we can also detect both Java and ABAP systems.

SOLMAN $ unzip -p 51054655_4.ZIP DATA_UNITS/JAVA_EXPORT/LABEL.ASC
SAP:JEXPORT:SR2_72SOLMAN_2020S4:*:*:*

SOLMAN $ unzip -p 51054655_1.ZIP LABEL.ASC
SAP:SOLMAN:SR27.2:DVD_EXPORT(1/2):SAP SOLUTION MANAGER 7.2 SR2 Installation Export DVD 1/2:D51054655_1

SOLMAN $ unzip -p 51054655_2.ZIP LABEL.ASC
SAP:SOLMAN:SR27.2:DVD_EXPORT(2/2):SAP SOLUTION MANAGER 7.2 SR2 Installation Export DVD 2/2:BD51054655_2

What do you think?