Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite sap_control role to use sapcontrol module out of sap_libs #6

Open
rainerleber opened this issue May 17, 2022 · 2 comments
Open

Comments

@rainerleber
Copy link
Collaborator

rewrite sap_control role to use sapcontrol module out of sap_libs

@kksat
Copy link

kksat commented May 17, 2022

Hello, Rainer
This is another topic, where I do not understand the intention. What reasons do you see to use sapcontrol module out of sap_libs if sapcontrol can be called as command with ansible. And it will be supported, because this is simple command call.
I would be very grateful if you could explain this design decision.

@rainerleber
Copy link
Collaborator Author

It's also an other purpose. Sapcontrol calls with command module will return strings and it's hard to parse the return value.
There is already logic wrapped around sapcontrol: https://github.com/sap-linuxlab/community.sap_operations/tree/main/roles/sap_control

To reduce the logic and extend it. It could be an effort to integrate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants