Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages related issues (in dev.app) - 4 #1800

Open
madhurrya opened this issue Jun 24, 2024 · 11 comments · Fixed by #1835
Open

Messages related issues (in dev.app) - 4 #1800

madhurrya opened this issue Jun 24, 2024 · 11 comments · Fixed by #1835
Assignees

Comments

@madhurrya
Copy link
Contributor

madhurrya commented Jun 24, 2024

FIXED 1. When a non admin user clicks on a message task, it gives this error

Image

Image

@madhurrya
Copy link
Contributor Author

  1. In the send messages, send data we show the sent data when we click 'View" like this.
    But in the Receive messages, the receive data is empty. Shouldn't it show the same there?

https://dev.app.spiff.status.im/i/3057
image

image

https://dev.app.spiff.status.im/i/3058

image

@burnettk
Copy link
Contributor

@madhurrya this might be another issue where the correlation name must not contain spaces. that might be something to try to make sure it acts the same way when there are no spaces.

@madhurrya
Copy link
Contributor Author

madhurrya commented Jun 25, 2024

@burnettk I didn't have a way to test this today as I keep getting this error #1809
image

@madhurrya
Copy link
Contributor Author

@burnettk tested it without adding a matching condition. In that case the receive data is empty.
Eventhough a matching condition is not set, it should still show the receive data right?

https://dev.app.spiff.status.im/i/3285
https://dev.app.spiff.status.im/i/3286

image

image

@madhurrya
Copy link
Contributor Author

And if you take this one here it shows Receive data even before the message completes. May be I have not understood the concept there?
https://dev.app.spiff.status.im/i/3291
image

image

@burnettk
Copy link
Contributor

maybe because of matching on empty correlations. we will take a look at this.

@github-project-automation github-project-automation bot moved this from Backlog to Resolved in SpiffWorkflow Jun 27, 2024
@jasquat jasquat reopened this Jun 28, 2024
@jasquat jasquat moved this from Resolved to In Progress in SpiffWorkflow Jun 28, 2024
@burnettk burnettk moved this from In Progress to Ready for QA in SpiffWorkflow Jun 28, 2024
@madhurrya
Copy link
Contributor Author

Issue 1 is fixed.
Issue 2 seems to be there for this instance - https://dev.app.spiff.status.im/i/4428
image

@madhurrya madhurrya moved this from Ready for QA to In Progress in SpiffWorkflow Jul 1, 2024
@jasquat
Copy link
Contributor

jasquat commented Jul 1, 2024

I think the new issue is slightly different and more interesting. The message receive task was started manually, not from a message start event, and was never given any correlation keys. This means its keys are empty and therefore it will receive any sender task for that same message.

I've always wondered if it should act like this. The problem being that a message that was mistakenly never given any keys could hijack ongoing conversations between other process instances.

@madhurrya
Copy link
Contributor Author

It has the correlation properties defined.

image

This is what we see in the throw event.

image

@jasquat
Copy link
Contributor

jasquat commented Jul 1, 2024

Yeah the properties have been defined but it was never given any values to those properties prior to running. Which is why it's a blank dict on the receive.

@madhurrya
Copy link
Contributor Author

Do you mean a matching condition?
From the sending side it's sending a value. I didn't get what you mean. How do we set values on the receiving side?

@burnettk burnettk added this to the Message Stability / Usability milestone Jul 2, 2024
@calexh-sar calexh-sar moved this from In Progress to Backlog in SpiffWorkflow Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants