Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI Migration: get forms into serialization #1936

Closed
burnettk opened this issue Jul 16, 2024 · 3 comments
Closed

PI Migration: get forms into serialization #1936

burnettk opened this issue Jul 16, 2024 · 3 comments

Comments

@burnettk
Copy link
Contributor

burnettk commented Jul 16, 2024

json schema forms are not part of the spiff serialization. as a result, if you start a process instance and then change a form json schema, you will not be allowed to migrate the instance to the new form definition (since the system does not see that there is any change that would warrant a migration). to mitigate this, we propose:

consider how to bring existing environments into alignment with the new approach.
discovered in #1922

@burnettk burnettk converted this from a draft issue Jul 16, 2024
@calexh-sar calexh-sar changed the title Migration: get forms into serialization PI Migration: get forms into serialization Jul 17, 2024
@calexh-sar calexh-sar assigned essweine and unassigned essweine Jul 17, 2024
@jasquat
Copy link
Contributor

jasquat commented Jul 17, 2024

We started this branch https://github.com/sartography/spiff-arena/tree/add-form-hash-to-serialize-spec but we are aborting on this for now.

@burnettk
Copy link
Contributor Author

burnettk commented Jul 17, 2024

we were thinking about adding a table, form_schema, to link up git revisions, form hashes, form filenames, and process model identifiers with their corresponding form contents. we know we need to get something into the serialization in order for the user task form definition to work seamlessly for process instance migration, so we also started writing a Custom converter for user tasks with some guidance from Elizabeth. we got hung up because actually getting the form schema hash turns out to be not at all straightforward. from inside the converter, we could figure out what process model the task spec is in, potentially, and do the filesystem and json operations to determine the hash, but this seems slow and potentially outside the scope of what a to_dict function is generally supposed to do. since this is not something that obviously affects myome, we'll set it aside for now.

@calexh-sar calexh-sar moved this from New Issue to Backlog in SpiffWorkflow Jul 22, 2024
@burnettk
Copy link
Contributor Author

merged this content into #1922 , so closing this as dup.

@github-project-automation github-project-automation bot moved this from Backlog to Resolved in SpiffWorkflow Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Resolved
Development

No branches or pull requests

3 participants