Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make requests an optional dependency #102

Closed
techalchemy opened this issue Jan 7, 2020 · 1 comment
Closed

Make requests an optional dependency #102

techalchemy opened this issue Jan 7, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@techalchemy
Copy link
Member

The only use of requests is for downloading a file in vistir.contextmanagers.open_file, which can be handled in full using urllib or urllib2. As such, I think it's appropriate for requests to become an optional extra.

See sarugaku/pythonfinder#78 for reference
@techalchemy techalchemy added the enhancement New feature or request label Jan 7, 2020
@techalchemy
Copy link
Member Author

This was resolved in #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@techalchemy