Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of Bandit #57

Closed
oscar345 opened this issue Feb 4, 2024 · 4 comments
Closed

Bump version of Bandit #57

oscar345 opened this issue Feb 4, 2024 · 4 comments

Comments

@oscar345
Copy link

oscar345 commented Feb 4, 2024

The current version of Phoenix depends on a more recent version of Bandit, however, site_encrypt uses a older version of bandit. This makes it not possible to compile the application.

Resolving Hex dependencies...
Resolution completed in 0.112s
Because site_encrypt >= 0.5.0 depends on bandit ~> 0.6 and your app depends on bandit ~> 1.2, site_encrypt >= 0.5.0 is forbidden.
So, because your app depends on site_encrypt ~> 0.5, version solving failed.
** (Mix) Hex dependency resolution failed
@sasa1977
Copy link
Owner

sasa1977 commented Feb 5, 2024

I think the way to go is bumping the dep requirement to "~> 1.0" in site_encrypt too. PR is welcome :-)

@Hermanverschooten
Copy link
Contributor

Hi @sasa1977, this has already been adapted by a PR I did a while ago, but there was no new release in the mean time.

@rkenzhebekov
Copy link

rkenzhebekov commented Feb 10, 2024

I guess we need v0.5.1? I was able to run the bandit 1.2.0 with the master branch. There is a deprecation warning warning: SampleWeb.Endpoint.init/2 is deprecated, but it is discussed in here: #58

@sasa1977
Copy link
Owner

Published 0.5.1. The init deprecation requires more work and breaking changes, so I'll deal with that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants