sass-rails couldn't delete `Sass::Plugin::Rack` #136

tricknotes · 2013-02-26T13:46:25Z

When Sass::Plugin::Rack is defined, sass-rails try to delete this middleware.
But middlewares are frozen in rails(4.0.0.beta1) and raise the following error:

can't modify frozen Array (RuntimeError)

The text was updated successfully, but these errors were encountered:

lwe · 2013-02-26T14:09:28Z

Jap, having the same issue. It appears that Rails modified the behavior that in an after_initialize block the middleware stack cannot be changed. The issue is in https://github.com/rails/sass-rails/blob/master/lib/sass/rails/railtie.rb#L32 - I tried to find the reason why this after_initialize block was added, but don't know the sass/rails internals thus no idea. At least it looks like it definitly is supposed to edit the middleware stack.

Anyhow as a workaround, I've created an initializer which does remove it before the after_initialize block tries to remove it.

# config/initializers/fix_sass_rails.rb
Rails.application.config.middleware.delete Sass::Plugin::Rack

rafaelfranca · 2013-02-26T14:15:23Z

Thank you for the report guys. I'll take a look later if nobody does first

lwe · 2013-02-26T14:52:20Z

@rafaelfranca would take a look, but I need some hints :)

The freeze was introduced by rails/rails#5911 and it looks like the culprit is haml, tried a blank slate application and started adding gems until it breaks: https://gist.github.com/lwe/5038969

rafaelfranca · 2013-02-26T15:11:00Z

@lwe try to use haml 4.0.0

lwe · 2013-02-26T15:14:39Z

^^ yes, upgrading haml to 4.0 solves the issue for me, thanks - though I think we should still get rid of that after_initialize block, because it's no longer allowed to modify the middleware in there by rails...

PS: silly me for not trying to upgrade haml earlier :)

rafaelfranca · 2013-02-26T15:15:57Z

Yes, it doesn't make sense to be an after_initialize block.

frodsan · 2013-04-30T20:18:03Z

@rafaelfranca Any thoughts to fix this?

rafaelfranca · 2013-04-30T20:33:10Z

@frodsan we should change that block to run before the last initializer

DavidBennettPIO · 2013-08-10T10:58:40Z

Hi guys, I have tried haml versions 4.0.1 ~ 4.0.3 and get this error...
(ruby-2.0.0-p247 rails-4.0.0 and sass-rails-4.0.0)

When I try haml-4.0.0 I get this error insted:

~/.rvm/gems/ruby-2.0.0-p247/gems/haml-4.0.0/lib/haml/sass_rails_filter.rb:5:in `<module:Filters>': uninitialized constant Sass::Rails::SassTemplate (NameError)

Removing haml or sass-rails removes both errors... but obviously makes my app unusable :(

Currently, I got this to work by using haml-4.0.3 and removing this from /lib/sass/rails/railtie.rb

    # Remove the sass middleware if it gets inadvertently enabled by applications.
    config.after_initialize do |app|
      app.config.middleware.delete(Sass::Plugin::Rack) if defined?(Sass::Plugin::Rack)
    end

Is there any negative impact in not deleting the middleware?

rafaelfranca · 2013-08-10T19:19:02Z

This error doesn't seems related with the after_initialize block since it is complaining about the Sass::Rails::SassTemplate that is not present in sass-rails anymore.

DavidBennettPIO · 2013-08-11T03:03:16Z

Sorry, what I meant was using haml-4.0.0 doesn’t work like in the previous comments.
(gives me the uninitialized constant Sass::Rails::SassTemplate (NameError) error)

But haml-4.0.1~3 give the can't modify frozen Array (RuntimeError) error.

What should I do to get a working haml + sass-rails config?

oleander · 2013-09-02T20:41:16Z

I'm having the same problem.

/Users/linus/.rvm/gems/ruby-2.0.0-p247/gems/actionpack-4.0.0/lib/action_dispatch/middleware/stack.rb:112:in push: can't modify frozen Array (RuntimeError)

Changing stack.rb:112 from

  def use(*args, &block)
      middleware = self.class::Middleware.new(*args, &block)
      self.middlewares.push(middleware)
  end

to

  def use(*args, &block)
      middleware = self.class::Middleware.new(*args, &block)
      self.middlewares += [middleware]
  end

temporarily solves the problem.

robin850 · 2013-09-03T08:29:04Z

@oleander : Could you please send a pull request with the given fix ?

dblock · 2013-10-22T21:01:38Z

I have the same problem and I am still confused to what a patch for this is. The suggested monkey patch by @oleander doesn't work for me, same error. I am using haml 4.0.3.

dblock · 2013-10-22T21:08:41Z

Uhm, ok, the fix is to remove require 'sass/plugin/rack' that was explicitly in my config.ru :) old code ...

taru-tci · 2013-11-27T20:25:11Z

Is there a patch for railties to remove
# Remove the sass middleware if it gets inadvertently enabled by applications.
config.after_initialize do |app|
app.config.middleware.delete(Sass::Plugin::Rack) if defined?(Sass::Plugin::Rack)
end

mlyubarskyy · 2013-12-04T11:28:46Z

works with

# config/initializers/fix_sass_rails.rb
Rails.application.config.middleware.delete Sass::Plugin::Rack

mjtko · 2014-11-10T17:58:44Z

Urgh, still not fixed. Having to hack this into my app now.

Traced it back to this, which changes the way the railtie works:

sass/sass@b03d373

Adding an initializer feels like a hack, but I'm not sure who should be handling this where really.

justin808 · 2015-10-16T10:29:44Z

Was this ever resolved? I'm hitting this one.

rafaelfranca · 2015-10-16T10:34:38Z

Could you create a sample application reproducing it?

justin808 · 2015-10-16T10:39:53Z

I don't think so. I'm upgrading a giant old rails project to Rails 4 with many old gems.

Any tip on how to trace down where this error is coming from:

RuntimeError:
can't modify frozen Array

The stack trace only tells me it's coming from my sass file.

mjtko · 2015-10-16T10:50:00Z

@justin808

In case it helps, here's how I've been working around this issue in an initializer:

  # mjt - if it has been added for any reason, remove badly added
  # Sass::Plugin::Rack middleware now, before it all falls apart in
  # sass-rails (see https://github.com/rails/sass-rails/issues/136)
  if defined?(Sass::Plugin::Rack)
    app.config.middleware.delete(Sass::Plugin::Rack)
  end

rafaelfranca · 2015-10-16T13:33:49Z

So PDI, you are in the best position to fix this issue for everyone since you are able to reproduce and with this find the cause and fix it.

There are actually two parts to the issue of not being able to migrate with this branch. The first is https://gist.github.com/eLobato/0f5db50b5c93cc6c277c and can be temporarily fixed with rails/sass-rails#136 (comment) I am not sure of a long term fix for that atm. Once that is patched, this error https://gist.github.com/johnpmitsch/96e5ba3629890931193a happens on a migration. This will fix that error by changing the Migrator class initializer arguments which have changed from rails 3 to rails 4

Counter cache columns fix Remove conditions,order,limit from has_many relations Remove test runner On minitest 5, the runner API was deprecated, so our custom test runner is no longer working. Remove useless add_index on lookup_values match An index is added previously on lookup_values :priority, and on Rails 4 rename_column changes 'priority' to 'match' already changes the name of the index. Alias assert_include to assert_includes Expire topbar cache Subclass ApplicationMailer in test to avoid 'missing template' error Fixes #12021 - Use .to_param to find parent object in LookupKeys controller On Rails 4, .find will not default to .friendly.find so find_hostgroup, find_environment and find_host will fail for non numeric IDs. However, we can use from_param to find these objects. This is something we can do both on Rails 3 and Rails 4, whereas using .friendly isn't an option until friendly_id 5.0, which depends on Rails 4. Use explicit friendly ID search Remove RecordNotFound errors from parameterizable in rails 4 find_common finder uses from_param -> friendly -> find The finder needed to be refactored because with the new Friendly ID we have to use .friendly explicitely. It currently follows the strategy of searching like this: - from_param -> .friendly -> regular find Protected attributes automatically added through AccessibleAttributes AccessibleAttributes pulls in all possible associations and models and sets them as attr_accessible for the model. Where needed, additional attr_accessible attributes have been added. refs theforeman#3157 - adding protected_attributes gem Conflicts: app/models/auth_source.rb app/models/domain.rb app/models/image.rb app/models/lookup_value.rb config/routes/test.rb Conflicts: app/models/domain.rb app/models/lookup_value.rb url_for doesn't append port when protocol is specified Some of our tests are checking if port 80 or 443 is included in the URL generated by lib/foreman/renderer.rb. However url_for has changed in Rails 4 and now it does not append the port even if explicitly added. If the protocol is specified, as it is in this case, then the url generated will just have the protocol (http or https) but not the port (80 or 443) Validate object instead of _id column in join tables On Rails 4 such validations will fail when we try to create objects without explicitely assigning the id. Puppetclass.new(:config_group => config_group) would fail even for a valid config group, :config_group_id => config_group.id should be used instead. To avoid that, we validate the object, not the ID column Rails 4 non backwards compatible syntax changes Changes that have to deal with how some of the internal Rails objects need a new syntax, like generating routes, exceptions, form builders. None of these are Rails 3 compatible. Fixes #12199 - rails 4 migration errors There are actually two parts to the issue of not being able to migrate with this branch. The first is https://gist.github.com/eLobato/0f5db50b5c93cc6c277c and can be temporarily fixed with rails/sass-rails#136 (comment) I am not sure of a long term fix for that atm. Once that is patched, this error https://gist.github.com/johnpmitsch/96e5ba3629890931193a happens on a migration. This will fix that error by changing the Migrator class initializer arguments which have changed from rails 3 to rails 4 Refactor fact value test to not modify user_roles directly Return external usergroupsas an array Use eager_load instead of references Other rails 4 particularities

This commits upgrades Rails to Rails 4.1.5. See a description of the changes included here, and go to the pull request in GitHub to see more detailed explanations: * Update gems to a Rails 4 compatible version, including dependencies * Fix counter cache columns * Remove conditions, order, limit from has_many relations * Remove test runner On minitest 5, the runner API was deprecated, so our custom test runner is no longer working. * Remove useless add_index on lookup_values match An index is added previously on lookup_values :priority, and on Rails 4 rename_column changes 'priority' to 'match' already changes the name of the index. * Alias assert_include to assert_includes. * Expire topbar cache * Subclass ApplicationMailer in test to avoid 'missing template' error * Fixes #12021 - Use .to_param to find parent object in LookupKeys controller On Rails 4, .find will not default to .friendly.find so find_hostgroup, find_environment and find_host will fail for non numeric IDs. However, we can use from_param to find these objects. This is something we can do both on Rails 3 and Rails 4, whereas using .friendly isn't an option until friendly_id 5.0, which depends on Rails 4. * Use explicit friendly ID search. * find_common finder uses from_param -> friendly -> find The finder needed to be refactored because with the new Friendly ID we have to use .friendly explicitely. It currently follows the strategy of searching like this: - from_param -> .friendly -> regular find * Remove RecordNotFound errors from parameterizable in rails 4 * Protect attributes using attr_accessible and protected_attributes * url_for doesn't append port when protocol is specified Some of our tests are checking if port 80 or 443 is included in the URL generated by lib/foreman/renderer.rb. However url_for has changed in Rails 4 and now it does not append the port even if explicitly added. If the protocol is specified, as it is in this case, then the url generated will just have the protocol (http or https) but not the port (80 or 443) * Validate object instead of _id column in join tables On Rails 4 such validations will fail when we try to create objects without explicitely assigning the id. Puppetclass.new(:config_group => config_group) would fail even for a valid config group, :config_group_id => config_group.id should be used instead. To avoid that, we validate the object, not the ID column * Rails 4 non backwards compatible syntax changes Changes that have to deal with how some of the internal Rails objects need a new syntax, like generating routes, exceptions, form builders. None of these are Rails 3 compatible. * Fixes #12199 - rails 4 migration errors There are actually two parts to the issue of not being able to migrate with this branch. The first is https://gist.github.com/eLobato/0f5db50b5c93cc6c277c and can be temporarily fixed with rails/sass-rails#136 (comment) I am not sure of a long term fix for that atm. Once that is patched, this error https://gist.github.com/johnpmitsch/96e5ba3629890931193a happens on a migration. This will fix that error by changing the Migrator class initializer arguments which have changed from rails 3 to rails 4 * Refactor fact value test to not modify user_roles directly * Return external usergroupsas an array * Use eager_load to preload associations to be used in where

This commits upgrades Rails to Rails 4.1.5. See a description of the changes included here, and go to the pull request in GitHub to see more detailed explanations: * Update gems to a Rails 4 compatible version, including dependencies * Fix counter cache columns * Remove conditions, order, limit from has_many relations * Remove test runner On minitest 5, the runner API was deprecated, so our custom test runner is no longer working. * Remove useless add_index on lookup_values match An index is added previously on lookup_values :priority, and on Rails 4 rename_column changes 'priority' to 'match' already changes the name of the index. * Alias assert_include to assert_includes. * Expire topbar cache * Subclass ApplicationMailer in test to avoid 'missing template' error * Fixes #12021 - Use .to_param to find parent object in LookupKeys controller On Rails 4, .find will not default to .friendly.find so find_hostgroup, find_environment and find_host will fail for non numeric IDs. However, we can use from_param to find these objects. This is something we can do both on Rails 3 and Rails 4, whereas using .friendly isn't an option until friendly_id 5.0, which depends on Rails 4. * Use explicit friendly ID search. * find_common finder uses from_param -> friendly -> find The finder needed to be refactored because with the new Friendly ID we have to use .friendly explicitely. It currently follows the strategy of searching like this: - from_param -> .friendly -> regular find * Remove RecordNotFound errors from parameterizable in rails 4 * Protect attributes using attr_accessible and protected_attributes * url_for doesn't append port when protocol is specified Some of our tests are checking if port 80 or 443 is included in the URL generated by lib/foreman/renderer.rb. However url_for has changed in Rails 4 and now it does not append the port even if explicitly added. If the protocol is specified, as it is in this case, then the url generated will just have the protocol (http or https) but not the port (80 or 443) * Validate object instead of _id column in join tables On Rails 4 such validations will fail when we try to create objects without explicitely assigning the id. Puppetclass.new(:config_group => config_group) would fail even for a valid config group, :config_group_id => config_group.id should be used instead. To avoid that, we validate the object, not the ID column * Rails 4 non backwards compatible syntax changes Changes that have to deal with how some of the internal Rails objects need a new syntax, like generating routes, exceptions, form builders. None of these are Rails 3 compatible. * Fixes #12199 - rails 4 migration errors There are actually two parts to the issue of not being able to migrate with this branch. The first is https://gist.github.com/eLobato/0f5db50b5c93cc6c277c and can be temporarily fixed with rails/sass-rails#136 (comment) I am not sure of a long term fix for that atm. Once that is patched, this error https://gist.github.com/johnpmitsch/96e5ba3629890931193a happens on a migration. This will fix that error by changing the Migrator class initializer arguments which have changed from rails 3 to rails 4 * Refactor fact value test to not modify user_roles directly * Return external usergroupsas an array * Use eager_load to preload associations to be used in where Fixes theforeman#7230, #12021 - Upgrade to Rails 4.1.5 This commits upgrades Rails to Rails 4.1.5. See a description of the changes included here, and go to the pull request in GitHub to see more detailed explanations: * Update gems to a Rails 4 compatible version, including dependencies * Fix counter cache columns * Remove conditions, order, limit from has_many relations * Remove test runner On minitest 5, the runner API was deprecated, so our custom test runner is no longer working. * Remove useless add_index on lookup_values match An index is added previously on lookup_values :priority, and on Rails 4 rename_column changes 'priority' to 'match' already changes the name of the index. * Alias assert_include to assert_includes. * Expire topbar cache * Subclass ApplicationMailer in test to avoid 'missing template' error * Fixes #12021 - Use .to_param to find parent object in LookupKeys controller On Rails 4, .find will not default to .friendly.find so find_hostgroup, find_environment and find_host will fail for non numeric IDs. However, we can use from_param to find these objects. This is something we can do both on Rails 3 and Rails 4, whereas using .friendly isn't an option until friendly_id 5.0, which depends on Rails 4. * Use explicit friendly ID search. * find_common finder uses from_param -> friendly -> find The finder needed to be refactored because with the new Friendly ID we have to use .friendly explicitely. It currently follows the strategy of searching like this: - from_param -> .friendly -> regular find * Remove RecordNotFound errors from parameterizable in rails 4 * Protect attributes using attr_accessible and protected_attributes * url_for doesn't append port when protocol is specified Some of our tests are checking if port 80 or 443 is included in the URL generated by lib/foreman/renderer.rb. However url_for has changed in Rails 4 and now it does not append the port even if explicitly added. If the protocol is specified, as it is in this case, then the url generated will just have the protocol (http or https) but not the port (80 or 443) * Validate object instead of _id column in join tables On Rails 4 such validations will fail when we try to create objects without explicitely assigning the id. Puppetclass.new(:config_group => config_group) would fail even for a valid config group, :config_group_id => config_group.id should be used instead. To avoid that, we validate the object, not the ID column * Rails 4 non backwards compatible syntax changes Changes that have to deal with how some of the internal Rails objects need a new syntax, like generating routes, exceptions, form builders. None of these are Rails 3 compatible. * Fixes #12199 - rails 4 migration errors There are actually two parts to the issue of not being able to migrate with this branch. The first is https://gist.github.com/eLobato/0f5db50b5c93cc6c277c and can be temporarily fixed with rails/sass-rails#136 (comment) I am not sure of a long term fix for that atm. Once that is patched, this error https://gist.github.com/johnpmitsch/96e5ba3629890931193a happens on a migration. This will fix that error by changing the Migrator class initializer arguments which have changed from rails 3 to rails 4 * Refactor fact value test to not modify user_roles directly * Return external usergroupsas an array * Use eager_load to preload associations to be used in where * Auto detect jenkins rake task in application.rb and set test RAILS_ENV in that case

This commits upgrades Rails to Rails 4.1.5. See a description of the changes included here, and go to the pull request in GitHub to see more detailed explanations: * Update gems to a Rails 4 compatible version, including dependencies * Fix counter cache columns * Remove conditions, order, limit from has_many relations * Remove test runner On minitest 5, the runner API was deprecated, so our custom test runner is no longer working. * Remove useless add_index on lookup_values match An index is added previously on lookup_values :priority, and on Rails 4 rename_column changes 'priority' to 'match' already changes the name of the index. * Alias assert_include to assert_includes. * Expire topbar cache * Subclass ApplicationMailer in test to avoid 'missing template' error * Fixes #12021 - Use .to_param to find parent object in LookupKeys controller On Rails 4, .find will not default to .friendly.find so find_hostgroup, find_environment and find_host will fail for non numeric IDs. However, we can use from_param to find these objects. This is something we can do both on Rails 3 and Rails 4, whereas using .friendly isn't an option until friendly_id 5.0, which depends on Rails 4. * Use explicit friendly ID search. * find_common finder uses from_param -> friendly -> find The finder needed to be refactored because with the new Friendly ID we have to use .friendly explicitely. It currently follows the strategy of searching like this: - from_param -> .friendly -> regular find * Remove RecordNotFound errors from parameterizable in rails 4 * Protect attributes using attr_accessible and protected_attributes * url_for doesn't append port when protocol is specified Some of our tests are checking if port 80 or 443 is included in the URL generated by lib/foreman/renderer.rb. However url_for has changed in Rails 4 and now it does not append the port even if explicitly added. If the protocol is specified, as it is in this case, then the url generated will just have the protocol (http or https) but not the port (80 or 443) * Validate object instead of _id column in join tables On Rails 4 such validations will fail when we try to create objects without explicitely assigning the id. Puppetclass.new(:config_group => config_group) would fail even for a valid config group, :config_group_id => config_group.id should be used instead. To avoid that, we validate the object, not the ID column * Rails 4 non backwards compatible syntax changes Changes that have to deal with how some of the internal Rails objects need a new syntax, like generating routes, exceptions, form builders. None of these are Rails 3 compatible. * Fixes #12199 - rails 4 migration errors There are actually two parts to the issue of not being able to migrate with this branch. The first is https://gist.github.com/eLobato/0f5db50b5c93cc6c277c and can be temporarily fixed with rails/sass-rails#136 (comment) I am not sure of a long term fix for that atm. Once that is patched, this error https://gist.github.com/johnpmitsch/96e5ba3629890931193a happens on a migration. This will fix that error by changing the Migrator class initializer arguments which have changed from rails 3 to rails 4 * Refactor fact value test to not modify user_roles directly * Return external usergroupsas an array * Use eager_load to preload associations to be used in where Fixes theforeman#7230, #12021 - Upgrade to Rails 4.1.5 This commits upgrades Rails to Rails 4.1.5. See a description of the changes included here, and go to the pull request in GitHub to see more detailed explanations: * Update gems to a Rails 4 compatible version, including dependencies * Fix counter cache columns * Remove conditions, order, limit from has_many relations * Remove test runner On minitest 5, the runner API was deprecated, so our custom test runner is no longer working. * Remove useless add_index on lookup_values match An index is added previously on lookup_values :priority, and on Rails 4 rename_column changes 'priority' to 'match' already changes the name of the index. * Alias assert_include to assert_includes. * Expire topbar cache * Subclass ApplicationMailer in test to avoid 'missing template' error * Fixes #12021 - Use .to_param to find parent object in LookupKeys controller On Rails 4, .find will not default to .friendly.find so find_hostgroup, find_environment and find_host will fail for non numeric IDs. However, we can use from_param to find these objects. This is something we can do both on Rails 3 and Rails 4, whereas using .friendly isn't an option until friendly_id 5.0, which depends on Rails 4. * Use explicit friendly ID search. * find_common finder uses from_param -> friendly -> find The finder needed to be refactored because with the new Friendly ID we have to use .friendly explicitely. It currently follows the strategy of searching like this: - from_param -> .friendly -> regular find * Remove RecordNotFound errors from parameterizable in rails 4 * Protect attributes using attr_accessible and protected_attributes * url_for doesn't append port when protocol is specified Some of our tests are checking if port 80 or 443 is included in the URL generated by lib/foreman/renderer.rb. However url_for has changed in Rails 4 and now it does not append the port even if explicitly added. If the protocol is specified, as it is in this case, then the url generated will just have the protocol (http or https) but not the port (80 or 443) * Validate object instead of _id column in join tables On Rails 4 such validations will fail when we try to create objects without explicitely assigning the id. Puppetclass.new(:config_group => config_group) would fail even for a valid config group, :config_group_id => config_group.id should be used instead. To avoid that, we validate the object, not the ID column * Rails 4 non backwards compatible syntax changes Changes that have to deal with how some of the internal Rails objects need a new syntax, like generating routes, exceptions, form builders. None of these are Rails 3 compatible. * Fixes #12199 - rails 4 migration errors There are actually two parts to the issue of not being able to migrate with this branch. The first is https://gist.github.com/eLobato/0f5db50b5c93cc6c277c and can be temporarily fixed with rails/sass-rails#136 (comment) I am not sure of a long term fix for that atm. Once that is patched, this error https://gist.github.com/johnpmitsch/96e5ba3629890931193a happens on a migration. This will fix that error by changing the Migrator class initializer arguments which have changed from rails 3 to rails 4 * Refactor fact value test to not modify user_roles directly * Return external usergroupsas an array * Use eager_load to preload associations to be used in where * Auto detect jenkins rake task in application.rb and set test RAILS_ENV in that case * Reference previously undigested assets in CSS and js as digested using asset-url or image-url

This commits upgrades Rails to Rails 4.1.5. See a description of the changes included here, and go to the pull request in GitHub to see more detailed explanations: * Update gems to a Rails 4 compatible version, including dependencies * Fix counter cache columns * Remove conditions, order, limit from has_many relations * Remove test runner On minitest 5, the runner API was deprecated, so our custom test runner is no longer working. * Remove useless add_index on lookup_values match An index is added previously on lookup_values :priority, and on Rails 4 rename_column changes 'priority' to 'match' already changes the name of the index. * Alias assert_include to assert_includes. * Expire topbar cache * Subclass ApplicationMailer in test to avoid 'missing template' error * Fixes #12021 - Use .to_param to find parent object in LookupKeys controller On Rails 4, .find will not default to .friendly.find so find_hostgroup, find_environment and find_host will fail for non numeric IDs. However, we can use from_param to find these objects. This is something we can do both on Rails 3 and Rails 4, whereas using .friendly isn't an option until friendly_id 5.0, which depends on Rails 4. * Use explicit friendly ID search. * find_common finder uses from_param -> friendly -> find The finder needed to be refactored because with the new Friendly ID we have to use .friendly explicitely. It currently follows the strategy of searching like this: - from_param -> .friendly -> regular find * Remove RecordNotFound errors from parameterizable in rails 4 * Protect attributes using attr_accessible and protected_attributes * url_for doesn't append port when protocol is specified Some of our tests are checking if port 80 or 443 is included in the URL generated by lib/foreman/renderer.rb. However url_for has changed in Rails 4 and now it does not append the port even if explicitly added. If the protocol is specified, as it is in this case, then the url generated will just have the protocol (http or https) but not the port (80 or 443) * Validate object instead of _id column in join tables On Rails 4 such validations will fail when we try to create objects without explicitely assigning the id. Puppetclass.new(:config_group => config_group) would fail even for a valid config group, :config_group_id => config_group.id should be used instead. To avoid that, we validate the object, not the ID column * Rails 4 non backwards compatible syntax changes Changes that have to deal with how some of the internal Rails objects need a new syntax, like generating routes, exceptions, form builders. None of these are Rails 3 compatible. * Fixes #12199 - rails 4 migration errors There are actually two parts to the issue of not being able to migrate with this branch. The first is https://gist.github.com/eLobato/0f5db50b5c93cc6c277c and can be temporarily fixed with rails/sass-rails#136 (comment) I am not sure of a long term fix for that atm. Once that is patched, this error https://gist.github.com/johnpmitsch/96e5ba3629890931193a happens on a migration. This will fix that error by changing the Migrator class initializer arguments which have changed from rails 3 to rails 4 * Refactor fact value test to not modify user_roles directly * Return external usergroupsas an array * Use eager_load to preload associations to be used in where Fixes theforeman#7230, #12021 - Upgrade to Rails 4.1.5 This commits upgrades Rails to Rails 4.1.5. See a description of the changes included here, and go to the pull request in GitHub to see more detailed explanations: * Update gems to a Rails 4 compatible version, including dependencies * Fix counter cache columns * Remove conditions, order, limit from has_many relations * Remove test runner On minitest 5, the runner API was deprecated, so our custom test runner is no longer working. * Remove useless add_index on lookup_values match An index is added previously on lookup_values :priority, and on Rails 4 rename_column changes 'priority' to 'match' already changes the name of the index. * Alias assert_include to assert_includes. * Expire topbar cache * Subclass ApplicationMailer in test to avoid 'missing template' error * Fixes #12021 - Use .to_param to find parent object in LookupKeys controller On Rails 4, .find will not default to .friendly.find so find_hostgroup, find_environment and find_host will fail for non numeric IDs. However, we can use from_param to find these objects. This is something we can do both on Rails 3 and Rails 4, whereas using .friendly isn't an option until friendly_id 5.0, which depends on Rails 4. * Use explicit friendly ID search. * find_common finder uses from_param -> friendly -> find The finder needed to be refactored because with the new Friendly ID we have to use .friendly explicitely. It currently follows the strategy of searching like this: - from_param -> .friendly -> regular find * Remove RecordNotFound errors from parameterizable in rails 4 * Protect attributes using attr_accessible and protected_attributes * url_for doesn't append port when protocol is specified Some of our tests are checking if port 80 or 443 is included in the URL generated by lib/foreman/renderer.rb. However url_for has changed in Rails 4 and now it does not append the port even if explicitly added. If the protocol is specified, as it is in this case, then the url generated will just have the protocol (http or https) but not the port (80 or 443) * Validate object instead of _id column in join tables On Rails 4 such validations will fail when we try to create objects without explicitely assigning the id. Puppetclass.new(:config_group => config_group) would fail even for a valid config group, :config_group_id => config_group.id should be used instead. To avoid that, we validate the object, not the ID column * Rails 4 non backwards compatible syntax changes Changes that have to deal with how some of the internal Rails objects need a new syntax, like generating routes, exceptions, form builders. None of these are Rails 3 compatible. * Fixes #12199 - rails 4 migration errors There are actually two parts to the issue of not being able to migrate with this branch. The first is https://gist.github.com/eLobato/0f5db50b5c93cc6c277c and can be temporarily fixed with rails/sass-rails#136 (comment) I am not sure of a long term fix for that atm. Once that is patched, this error https://gist.github.com/johnpmitsch/96e5ba3629890931193a happens on a migration. This will fix that error by changing the Migrator class initializer arguments which have changed from rails 3 to rails 4 * Refactor fact value test to not modify user_roles directly * Return external usergroupsas an array * Use eager_load to preload associations to be used in where * Auto detect jenkins rake task in application.rb and set test RAILS_ENV in that case * Reference previously undigested assets in CSS and js as digested using asset-url or image-url * Adapted sprockets manifest.json instead of manifest.yml (ehelms)

This commits upgrades Rails to Rails 4.1.5. See a description of the changes included here, and go to the pull request in GitHub to see more detailed explanations: * Update gems to a Rails 4 compatible version, including dependencies * Fix counter cache columns * Remove conditions, order, limit from has_many relations * Remove test runner On minitest 5, the runner API was deprecated, so our custom test runner is no longer working. * Remove useless add_index on lookup_values match An index is added previously on lookup_values :priority, and on Rails 4 rename_column changes 'priority' to 'match' already changes the name of the index. * Alias assert_include to assert_includes. * Expire topbar cache * Subclass ApplicationMailer in test to avoid 'missing template' error * Fixes #12021 - Use .to_param to find parent object in LookupKeys controller On Rails 4, .find will not default to .friendly.find so find_hostgroup, find_environment and find_host will fail for non numeric IDs. However, we can use from_param to find these objects. This is something we can do both on Rails 3 and Rails 4, whereas using .friendly isn't an option until friendly_id 5.0, which depends on Rails 4. * Use explicit friendly ID search. * find_common finder uses from_param -> friendly -> find The finder needed to be refactored because with the new Friendly ID we have to use .friendly explicitely. It currently follows the strategy of searching like this: - from_param -> .friendly -> regular find * Remove RecordNotFound errors from parameterizable in rails 4 * Protect attributes using attr_accessible and protected_attributes * url_for doesn't append port when protocol is specified Some of our tests are checking if port 80 or 443 is included in the URL generated by lib/foreman/renderer.rb. However url_for has changed in Rails 4 and now it does not append the port even if explicitly added. If the protocol is specified, as it is in this case, then the url generated will just have the protocol (http or https) but not the port (80 or 443) * Validate object instead of _id column in join tables On Rails 4 such validations will fail when we try to create objects without explicitely assigning the id. Puppetclass.new(:config_group => config_group) would fail even for a valid config group, :config_group_id => config_group.id should be used instead. To avoid that, we validate the object, not the ID column * Rails 4 non backwards compatible syntax changes Changes that have to deal with how some of the internal Rails objects need a new syntax, like generating routes, exceptions, form builders. None of these are Rails 3 compatible. * Fixes #12199 - rails 4 migration errors There are actually two parts to the issue of not being able to migrate with this branch. The first is https://gist.github.com/eLobato/0f5db50b5c93cc6c277c and can be temporarily fixed with rails/sass-rails#136 (comment) I am not sure of a long term fix for that atm. Once that is patched, this error https://gist.github.com/johnpmitsch/96e5ba3629890931193a happens on a migration. This will fix that error by changing the Migrator class initializer arguments which have changed from rails 3 to rails 4 * Refactor fact value test to not modify user_roles directly * Return external usergroupsas an array * Use eager_load to preload associations to be used in where Fixes #7230, #12021 - Upgrade to Rails 4.1.5 This commits upgrades Rails to Rails 4.1.5. See a description of the changes included here, and go to the pull request in GitHub to see more detailed explanations: * Update gems to a Rails 4 compatible version, including dependencies * Fix counter cache columns * Remove conditions, order, limit from has_many relations * Remove test runner On minitest 5, the runner API was deprecated, so our custom test runner is no longer working. * Remove useless add_index on lookup_values match An index is added previously on lookup_values :priority, and on Rails 4 rename_column changes 'priority' to 'match' already changes the name of the index. * Alias assert_include to assert_includes. * Expire topbar cache * Subclass ApplicationMailer in test to avoid 'missing template' error * Fixes #12021 - Use .to_param to find parent object in LookupKeys controller On Rails 4, .find will not default to .friendly.find so find_hostgroup, find_environment and find_host will fail for non numeric IDs. However, we can use from_param to find these objects. This is something we can do both on Rails 3 and Rails 4, whereas using .friendly isn't an option until friendly_id 5.0, which depends on Rails 4. * Use explicit friendly ID search. * find_common finder uses from_param -> friendly -> find The finder needed to be refactored because with the new Friendly ID we have to use .friendly explicitely. It currently follows the strategy of searching like this: - from_param -> .friendly -> regular find * Remove RecordNotFound errors from parameterizable in rails 4 * Protect attributes using attr_accessible and protected_attributes * url_for doesn't append port when protocol is specified Some of our tests are checking if port 80 or 443 is included in the URL generated by lib/foreman/renderer.rb. However url_for has changed in Rails 4 and now it does not append the port even if explicitly added. If the protocol is specified, as it is in this case, then the url generated will just have the protocol (http or https) but not the port (80 or 443) * Validate object instead of _id column in join tables On Rails 4 such validations will fail when we try to create objects without explicitely assigning the id. Puppetclass.new(:config_group => config_group) would fail even for a valid config group, :config_group_id => config_group.id should be used instead. To avoid that, we validate the object, not the ID column * Rails 4 non backwards compatible syntax changes Changes that have to deal with how some of the internal Rails objects need a new syntax, like generating routes, exceptions, form builders. None of these are Rails 3 compatible. * Fixes #12199 - rails 4 migration errors There are actually two parts to the issue of not being able to migrate with this branch. The first is https://gist.github.com/eLobato/0f5db50b5c93cc6c277c and can be temporarily fixed with rails/sass-rails#136 (comment) I am not sure of a long term fix for that atm. Once that is patched, this error https://gist.github.com/johnpmitsch/96e5ba3629890931193a happens on a migration. This will fix that error by changing the Migrator class initializer arguments which have changed from rails 3 to rails 4 * Refactor fact value test to not modify user_roles directly * Return external usergroupsas an array * Use eager_load to preload associations to be used in where * Auto detect jenkins rake task in application.rb and set test RAILS_ENV in that case * Reference previously undigested assets in CSS and js as digested using asset-url or image-url * Adapted sprockets manifest.json instead of manifest.yml (ehelms)

This commits upgrades Rails to Rails 4.1.5. See a description of the changes included here, and go to the pull request in GitHub to see more detailed explanations: * Update gems to a Rails 4 compatible version, including dependencies * Fix counter cache columns * Remove conditions, order, limit from has_many relations * Remove test runner On minitest 5, the runner API was deprecated, so our custom test runner is no longer working. * Remove useless add_index on lookup_values match An index is added previously on lookup_values :priority, and on Rails 4 rename_column changes 'priority' to 'match' already changes the name of the index. * Alias assert_include to assert_includes. * Expire topbar cache * Subclass ApplicationMailer in test to avoid 'missing template' error * Fixes #12021 - Use .to_param to find parent object in LookupKeys controller On Rails 4, .find will not default to .friendly.find so find_hostgroup, find_environment and find_host will fail for non numeric IDs. However, we can use from_param to find these objects. This is something we can do both on Rails 3 and Rails 4, whereas using .friendly isn't an option until friendly_id 5.0, which depends on Rails 4. * Use explicit friendly ID search. * find_common finder uses from_param -> friendly -> find The finder needed to be refactored because with the new Friendly ID we have to use .friendly explicitely. It currently follows the strategy of searching like this: - from_param -> .friendly -> regular find * Remove RecordNotFound errors from parameterizable in rails 4 * Protect attributes using attr_accessible and protected_attributes * url_for doesn't append port when protocol is specified Some of our tests are checking if port 80 or 443 is included in the URL generated by lib/foreman/renderer.rb. However url_for has changed in Rails 4 and now it does not append the port even if explicitly added. If the protocol is specified, as it is in this case, then the url generated will just have the protocol (http or https) but not the port (80 or 443) * Validate object instead of _id column in join tables On Rails 4 such validations will fail when we try to create objects without explicitely assigning the id. Puppetclass.new(:config_group => config_group) would fail even for a valid config group, :config_group_id => config_group.id should be used instead. To avoid that, we validate the object, not the ID column * Rails 4 non backwards compatible syntax changes Changes that have to deal with how some of the internal Rails objects need a new syntax, like generating routes, exceptions, form builders. None of these are Rails 3 compatible. * Fixes #12199 - rails 4 migration errors There are actually two parts to the issue of not being able to migrate with this branch. The first is https://gist.github.com/eLobato/0f5db50b5c93cc6c277c and can be temporarily fixed with rails/sass-rails#136 (comment) I am not sure of a long term fix for that atm. Once that is patched, this error https://gist.github.com/johnpmitsch/96e5ba3629890931193a happens on a migration. This will fix that error by changing the Migrator class initializer arguments which have changed from rails 3 to rails 4 * Refactor fact value test to not modify user_roles directly * Return external usergroupsas an array * Use eager_load to preload associations to be used in where Fixes theforeman#7230, #12021 - Upgrade to Rails 4.1.5 This commits upgrades Rails to Rails 4.1.5. See a description of the changes included here, and go to the pull request in GitHub to see more detailed explanations: * Update gems to a Rails 4 compatible version, including dependencies * Fix counter cache columns * Remove conditions, order, limit from has_many relations * Remove test runner On minitest 5, the runner API was deprecated, so our custom test runner is no longer working. * Remove useless add_index on lookup_values match An index is added previously on lookup_values :priority, and on Rails 4 rename_column changes 'priority' to 'match' already changes the name of the index. * Alias assert_include to assert_includes. * Expire topbar cache * Subclass ApplicationMailer in test to avoid 'missing template' error * Fixes #12021 - Use .to_param to find parent object in LookupKeys controller On Rails 4, .find will not default to .friendly.find so find_hostgroup, find_environment and find_host will fail for non numeric IDs. However, we can use from_param to find these objects. This is something we can do both on Rails 3 and Rails 4, whereas using .friendly isn't an option until friendly_id 5.0, which depends on Rails 4. * Use explicit friendly ID search. * find_common finder uses from_param -> friendly -> find The finder needed to be refactored because with the new Friendly ID we have to use .friendly explicitely. It currently follows the strategy of searching like this: - from_param -> .friendly -> regular find * Remove RecordNotFound errors from parameterizable in rails 4 * Protect attributes using attr_accessible and protected_attributes * url_for doesn't append port when protocol is specified Some of our tests are checking if port 80 or 443 is included in the URL generated by lib/foreman/renderer.rb. However url_for has changed in Rails 4 and now it does not append the port even if explicitly added. If the protocol is specified, as it is in this case, then the url generated will just have the protocol (http or https) but not the port (80 or 443) * Validate object instead of _id column in join tables On Rails 4 such validations will fail when we try to create objects without explicitely assigning the id. Puppetclass.new(:config_group => config_group) would fail even for a valid config group, :config_group_id => config_group.id should be used instead. To avoid that, we validate the object, not the ID column * Rails 4 non backwards compatible syntax changes Changes that have to deal with how some of the internal Rails objects need a new syntax, like generating routes, exceptions, form builders. None of these are Rails 3 compatible. * Fixes #12199 - rails 4 migration errors There are actually two parts to the issue of not being able to migrate with this branch. The first is https://gist.github.com/eLobato/0f5db50b5c93cc6c277c and can be temporarily fixed with rails/sass-rails#136 (comment) I am not sure of a long term fix for that atm. Once that is patched, this error https://gist.github.com/johnpmitsch/96e5ba3629890931193a happens on a migration. This will fix that error by changing the Migrator class initializer arguments which have changed from rails 3 to rails 4 * Refactor fact value test to not modify user_roles directly * Return external usergroupsas an array * Use eager_load to preload associations to be used in where * Auto detect jenkins rake task in application.rb and set test RAILS_ENV in that case * Reference previously undigested assets in CSS and js as digested using asset-url or image-url * Adapted sprockets manifest.json instead of manifest.yml (ehelms)

daqo · 2016-02-12T00:29:37Z

In case still anyone faces the problem, try to use config.app_middleware.use.
https://stackoverflow.com/questions/34444757/controlling-rails-initializer-load-order-possible-need-for-new-rails-initializa

johnpmitsch mentioned this issue Oct 16, 2015

Fixes #12199 - rails 4 migration errors dLobatog/foreman#14

Closed

dLobatog mentioned this issue Oct 28, 2015

Fixes #7230, #12021 - Upgrade to Rails 4.1.5 theforeman/foreman#2870

Closed

wjordan mentioned this issue Sep 2, 2016

try app_middleware instead of middleware #386

Closed

guilleiguaran closed this as completed Mar 24, 2019

Hamms mentioned this issue Oct 1, 2020

try app_middleware instead of middleware sass/sassc-rails#153

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sass-rails couldn't delete `Sass::Plugin::Rack` #136

sass-rails couldn't delete `Sass::Plugin::Rack` #136

tricknotes commented Feb 26, 2013

lwe commented Feb 26, 2013

rafaelfranca commented Feb 26, 2013

lwe commented Feb 26, 2013

rafaelfranca commented Feb 26, 2013

lwe commented Feb 26, 2013

rafaelfranca commented Feb 26, 2013

frodsan commented Apr 30, 2013

rafaelfranca commented Apr 30, 2013

DavidBennettPIO commented Aug 10, 2013

rafaelfranca commented Aug 10, 2013

DavidBennettPIO commented Aug 11, 2013

oleander commented Sep 2, 2013

robin850 commented Sep 3, 2013

dblock commented Oct 22, 2013

dblock commented Oct 22, 2013

taru-tci commented Nov 27, 2013

mlyubarskyy commented Dec 4, 2013

mjtko commented Nov 10, 2014

justin808 commented Oct 16, 2015

rafaelfranca commented Oct 16, 2015

justin808 commented Oct 16, 2015

mjtko commented Oct 16, 2015

rafaelfranca commented Oct 16, 2015

daqo commented Feb 12, 2016

sass-rails couldn't delete Sass::Plugin::Rack #136

sass-rails couldn't delete Sass::Plugin::Rack #136

Comments

tricknotes commented Feb 26, 2013

lwe commented Feb 26, 2013

rafaelfranca commented Feb 26, 2013

lwe commented Feb 26, 2013

rafaelfranca commented Feb 26, 2013

lwe commented Feb 26, 2013

rafaelfranca commented Feb 26, 2013

frodsan commented Apr 30, 2013

rafaelfranca commented Apr 30, 2013

DavidBennettPIO commented Aug 10, 2013

rafaelfranca commented Aug 10, 2013

DavidBennettPIO commented Aug 11, 2013

oleander commented Sep 2, 2013

robin850 commented Sep 3, 2013

dblock commented Oct 22, 2013

dblock commented Oct 22, 2013

taru-tci commented Nov 27, 2013

mlyubarskyy commented Dec 4, 2013

mjtko commented Nov 10, 2014

justin808 commented Oct 16, 2015

rafaelfranca commented Oct 16, 2015

justin808 commented Oct 16, 2015

mjtko commented Oct 16, 2015

rafaelfranca commented Oct 16, 2015

daqo commented Feb 12, 2016

sass-rails couldn't delete `Sass::Plugin::Rack` #136

sass-rails couldn't delete `Sass::Plugin::Rack` #136