Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid confusion in error message when remote server cannot be reached #56

Open
Th3Fanbus opened this issue Jan 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Th3Fanbus
Copy link

What happened?

When connecting to the remote (e.g. FTP) server fails, the error message confusingly mentions failed reading FactoryGame.exe before failed to dial host since reading the file is the first operation that ficsit-cli performs on the remote:

image

Context:
https://discord.com/channels/555424930502541343/555782140533407764/1194108885267656715
https://discord.com/channels/555424930502541343/555782140533407764/1194198329865801790

Version

No idea, latest at the time of writing?

What OS are you seeing the problem on?

Linux

What architecture are you seeing the problem on?

None

Relevant log output

No response

Any extra info:

No response

@Th3Fanbus Th3Fanbus added the bug Something isn't working label Jan 9, 2024
@mircearoata
Copy link
Member

Two things should be done regarding this:

  • wrapping the error text, similar to the apply scene
  • checking the connection by checking if the given directory exists (probably in i.Validate), which would give a better start to the error stack, something along the lines of failed to validate installation: failed reading {installPath}: failed acquiring connection: etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants