Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write test case where a hook accepts *args or **kwargs #5

Open
dzervas opened this issue Jan 4, 2020 · 0 comments
Open

Write test case where a hook accepts *args or **kwargs #5

dzervas opened this issue Jan 4, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@dzervas
Copy link
Member

dzervas commented Jan 4, 2020

I think the way that I count the arguments available in a hook is flawed.

In case a single (1) argument is *args, it should accept unlimited arguments. Same with **kwargs for keyword arguments.

Also there is a corner case for usage of *__retvals__ or **__retvals__

I should at least add it to the test cases - I think it won't work as expected (hooker will think that the hook accepts only 1 argument)

@dzervas dzervas added the bug Something isn't working label Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant