Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write out the config to / #26

Open
gracenoah opened this issue Jan 30, 2019 · 0 comments · May be fixed by #30
Open

Don't write out the config to / #26

gracenoah opened this issue Jan 30, 2019 · 0 comments · May be fixed by #30

Comments

@gracenoah
Copy link

Currently the config is written to a file in /. This requires

  1. That the container runs as root
  2. That the container's filesystem is writable

See https://github.com/satoshipay/docker-stellar-core/blob/master/confd/conf.d/stellar-core.cfg.toml#L3

This should be changed to any other subdirectory, such as /config so that the user of this image can make the container filesystem read only and/or control the user that it runs under.

@gracenoah gracenoah linked a pull request Oct 10, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant