Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[errors-] fix error-recent always showing "no error" #2620

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[errors-] fix error-recent always showing "no error" #2620

merged 1 commit into from
Dec 2, 2024

Conversation

midichef
Copy link
Contributor

@midichef midichef commented Dec 2, 2024

error-recent outputs no error in the statusbar even when an error exists to be inspected, because vd.push() only ever returns None.

saulpw
saulpw approved these changes Dec 2, 2024
View reviewed changes
Copy link
Owner

@saulpw saulpw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now that Python is different than Perl :)

@anjakefala anjakefala merged commit 37f0a0c into saulpw:develop Dec 2, 2024
14 checks passed
@midichef midichef deleted the error_recent_status branch December 2, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulpw saulpw saulpw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@midichef @saulpw @anjakefala