Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the byteOffset/charOffset from Region object for replacements #17

Open
kgevorkyan opened this issue Dec 22, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@kgevorkyan
Copy link
Member

Sarif supports several options for identify the place of warning/fixes via Region object:

  1. By indicating the lines and columns
  2. By indicating the byteOffset/charOffset and byteLength/charLength

For now we expect only lines and columns for indicating fix object, but it probably necessary to support byte offsets too

See https://docs.oasis-open.org/sarif/sarif/v2.1.0/os/sarif-v2.1.0-os.html#_Toc34317889

Under this issue we probably can introduce introduce our own model here. And make differences on class level: ReplacementByLine, ReplacementByOffset and etc., as suggested by @nulls

@kgevorkyan kgevorkyan added the enhancement New feature or request label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant