Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_simulation.py runs very slowly #204

Closed
sbenthall opened this issue Mar 21, 2023 · 3 comments
Closed

test_simulation.py runs very slowly #204

sbenthall opened this issue Mar 21, 2023 · 3 comments

Comments

@sbenthall
Copy link
Owner

The automated tests in test_simulation.py hang for an unusually long amount of time.
Would be good to trim this down somehow.

@alanlujan91
Copy link
Collaborator

This might have to do with the deepcopying of agents when explode_agents gets called. One way to reduce this time would be to reduce num_by_type parameter, to maybe 2 just for simple testing of the feature.

@sbenthall
Copy link
Owner Author

You might be right. But I am surprised that deepcopying takes so long. Have you timed it? I know you mentioned it.
If that is the bottleneck, there may be more efficient ways to create multiple identical agents (like, building them all with the AgentType constructor).

Yes, reducing num_by_type for the test would make sense. But

@sbenthall
Copy link
Owner Author

I think we identified that the problem was #205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants