chore: Dependency updates #247
clippy
4 errors
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 4 |
| Warning | 0 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.85.0-nightly (dff3e7ccd 2024-11-26)
- cargo 1.85.0-nightly (4c39aaff6 2024-11-25)
- clippy 0.1.84 (dff3e7ccd4 2024-11-26)
Annotations
Check failure on line 49 in breakwater/src/sinks/vnc.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'a
error: the following explicit lifetimes could be elided: 'a
--> breakwater/src/sinks/vnc.rs:49:13
|
49 | unsafe impl<'a, FB: FrameBuffer> Send for VncSink<'a, FB> {}
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `-D clippy::needless-lifetimes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
|
49 - unsafe impl<'a, FB: FrameBuffer> Send for VncSink<'a, FB> {}
49 + unsafe impl<FB: FrameBuffer> Send for VncSink<'_, FB> {}
|
Check failure on line 273 in breakwater/src/server.rs
github-actions / clippy
this loop could be written as a `while let` loop
error: this loop could be written as a `while let` loop
--> breakwater/src/server.rs:190:5
|
190 | / loop {
191 | | // Fill the buffer up with new data from the socket
192 | | // If there are any bytes left over from the previous loop iteration leave them as is and but the new data behind
193 | | let bytes_read = match stream
... |
272 | | }
273 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
= note: `-D clippy::while-let-loop` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::while_let_loop)]`
help: try
|
190 ~ while let Ok(bytes_read) = stream
191 + .read(&mut buffer[leftover_bytes_in_buffer..network_buffer_size - parser_lookahead])
192 + .await { .. }
|
Check failure on line 49 in breakwater/src/sinks/vnc.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'a
error: the following explicit lifetimes could be elided: 'a
--> breakwater/src/sinks/vnc.rs:49:13
|
49 | unsafe impl<'a, FB: FrameBuffer> Send for VncSink<'a, FB> {}
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `-D clippy::needless-lifetimes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
|
49 - unsafe impl<'a, FB: FrameBuffer> Send for VncSink<'a, FB> {}
49 + unsafe impl<FB: FrameBuffer> Send for VncSink<'_, FB> {}
|
Check failure on line 273 in breakwater/src/server.rs
github-actions / clippy
this loop could be written as a `while let` loop
error: this loop could be written as a `while let` loop
--> breakwater/src/server.rs:190:5
|
190 | / loop {
191 | | // Fill the buffer up with new data from the socket
192 | | // If there are any bytes left over from the previous loop iteration leave them as is and but the new data behind
193 | | let bytes_read = match stream
... |
272 | | }
273 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
= note: `-D clippy::while-let-loop` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::while_let_loop)]`
help: try
|
190 ~ while let Ok(bytes_read) = stream
191 + .read(&mut buffer[leftover_bytes_in_buffer..network_buffer_size - parser_lookahead])
192 + .await { .. }
|