switch to legacy_tox_ini, remove tox-ini-fmt. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed tox-dev/tox-ini-fmt#42, which makes it hard to use comments in tox.ini. Auto-formatting tox.ini was the main motivation to use a separate tox.ini at all, so just keep everything in pyproject.toml. Maybe tox will eventually have first-party support for pyproject.toml; this will make the transition that much simpler. It appears that tox==3.21.4 (appears on on ubuntu-22.04) can't actually parse the legacy_tox_ini option, and so does not get to the point of provisioning a tox environment for the approrpiate version. We now do proper provisioning ourselves in github ci.
sbrudenell
force-pushed
the
legacy-tox-ini
branch
from
e98fabe
to
53d58d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed tox-dev/tox-ini-fmt#42, which makes it hard to use comments in tox.ini. Auto-formatting tox.ini was the main motivation to use a separate tox.ini at all, so just keep everything in pyproject.toml.
Maybe tox will eventually have first-party support for pyproject.toml; this will make the transition that much simpler.