Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate source_date from ABACUS #17

Open
egli opened this issue Apr 17, 2015 · 2 comments
Open

Validate source_date from ABACUS #17

egli opened this issue Apr 17, 2015 · 2 comments
Labels
ready

Comments

@egli
Copy link
Member

egli commented Apr 17, 2015

The basic problem is that when ABACUS sends a source_edition which is not of the form "2004" or "blah / 2004" the source_date will be null.

Is this a problem? Well, maybe not. The source_date will be used to generate a bunch of meta data in DTBook, rdf or ncc files for example. A nil value will just generate the empty string.
@egli egli modified the milestone: 1.0 Apr 21, 2015
@egli egli added in progress and removed ready labels Apr 30, 2015
@egli
Copy link
Member Author

egli commented Apr 30, 2015

According to http://www.daisy.org/z3986/2005/Z3986-2005.html#PubMed it is optional but should contain a date, so if is empty I guess we should just not emit it.

@egli
Copy link
Member Author

egli commented Apr 30, 2015

Basically the problem manifests itself in dtb/xml.clj and dtbook.clj. In both places we could make the emit process depend on the value of the meta data. This seems a bit of a sweeping change though.

@egli egli added ready and removed in progress labels May 7, 2015
@egli egli removed this from the 1.0 milestone Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@egli