fix #41 test-08-failOnClassesExcludedFromJarStar #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @xuwei-k |
|
I'm confused about what's going on here actually now... will look into it more later |
larsrh
reviewed
Aug 15, 2017
.travis.yml
Outdated
| @@ -1,4 +1,5 @@ | |||
| language: scala | |||
| sudo: false | |||
| script: sbt scripted | |||
There was a problem hiding this comment.
There are also test cases that need to be run, so sbt test is required.
@ktoso pretty sure that the |
|
I missed your reply here, sorry about that @larsrh ! Will try then! |
No worries, I have no recollection of even posting that comment 😆 |
|
Yeah I'd also rather not remember any work on anything osgi related ;) |
|
I think it SHOULD fail then... leaving this open for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #41
The replacing was too aggressive leading to wrong things happening; we just want to drop the trailing .* if present