From b5b335824c441ec84236a6d7415080497b9a3fcc Mon Sep 17 00:00:00 2001 From: Sotatek-SonNguyen2 Date: Wed, 13 Oct 2021 15:24:02 +0700 Subject: [PATCH 1/6] remove ViewPropTypes disappeared --- RNAdMobBanner.js | 2 -- RNPublisherBanner.js | 2 -- 2 files changed, 4 deletions(-) diff --git a/RNAdMobBanner.js b/RNAdMobBanner.js index 7dc09e10d..e89000ecf 100644 --- a/RNAdMobBanner.js +++ b/RNAdMobBanner.js @@ -4,7 +4,6 @@ import { findNodeHandle, requireNativeComponent, UIManager, - ViewPropTypes, } from 'react-native'; import { createErrorFromErrorData } from './utils'; @@ -62,7 +61,6 @@ class AdMobBanner extends Component { AdMobBanner.simulatorId = 'SIMULATOR'; AdMobBanner.propTypes = { - ...ViewPropTypes, /** * AdMob iOS library banner size constants diff --git a/RNPublisherBanner.js b/RNPublisherBanner.js index 64aa12014..92f8dc733 100644 --- a/RNPublisherBanner.js +++ b/RNPublisherBanner.js @@ -4,7 +4,6 @@ import { findNodeHandle, requireNativeComponent, UIManager, - ViewPropTypes, } from 'react-native'; import { createErrorFromErrorData } from './utils'; @@ -71,7 +70,6 @@ class PublisherBanner extends Component { PublisherBanner.simulatorId = 'SIMULATOR'; PublisherBanner.propTypes = { - ...ViewPropTypes, /** * DFP iOS library banner size constants From 2218fc39b4d1f0b34fc1ef38f9f28b52f095594f Mon Sep 17 00:00:00 2001 From: Sotatek-SonNguyen2 Date: Wed, 13 Oct 2021 15:35:19 +0700 Subject: [PATCH 2/6] remove requireNativeComponent --- RNAdMobBanner.js | 3 ++- RNPublisherBanner.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/RNAdMobBanner.js b/RNAdMobBanner.js index e89000ecf..64efb86b3 100644 --- a/RNAdMobBanner.js +++ b/RNAdMobBanner.js @@ -2,7 +2,6 @@ import { arrayOf, func, string } from 'prop-types'; import React, { Component } from 'react'; import { findNodeHandle, - requireNativeComponent, UIManager, } from 'react-native'; import { createErrorFromErrorData } from './utils'; @@ -99,6 +98,8 @@ AdMobBanner.propTypes = { onAdLeftApplication: func, }; +const requireNativeComponent = (str) => null; + const RNGADBannerView = requireNativeComponent('RNGADBannerView', AdMobBanner); export default AdMobBanner; diff --git a/RNPublisherBanner.js b/RNPublisherBanner.js index 92f8dc733..2a86bbaba 100644 --- a/RNPublisherBanner.js +++ b/RNPublisherBanner.js @@ -2,7 +2,6 @@ import { arrayOf, func, string } from 'prop-types'; import React, { Component } from 'react'; import { findNodeHandle, - requireNativeComponent, UIManager, } from 'react-native'; import { createErrorFromErrorData } from './utils'; @@ -114,6 +113,8 @@ PublisherBanner.propTypes = { onAppEvent: func, }; +const requireNativeComponent = (str) => null; + const RNDFPBannerView = requireNativeComponent( 'RNDFPBannerView', PublisherBanner From bfa8582d4ffc580cfd158f3daa258d11583fd22d Mon Sep 17 00:00:00 2001 From: "hieu.do2" Date: Wed, 20 Oct 2021 10:29:55 +0700 Subject: [PATCH 3/6] fix-bug/fix-build-android: fix build android --- RNAdMobBanner.js | 3 +-- android/build.gradle | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/RNAdMobBanner.js b/RNAdMobBanner.js index 64efb86b3..ca081a99d 100644 --- a/RNAdMobBanner.js +++ b/RNAdMobBanner.js @@ -3,6 +3,7 @@ import React, { Component } from 'react'; import { findNodeHandle, UIManager, + requireNativeComponent, } from 'react-native'; import { createErrorFromErrorData } from './utils'; @@ -98,8 +99,6 @@ AdMobBanner.propTypes = { onAdLeftApplication: func, }; -const requireNativeComponent = (str) => null; - const RNGADBannerView = requireNativeComponent('RNGADBannerView', AdMobBanner); export default AdMobBanner; diff --git a/android/build.gradle b/android/build.gradle index 0b89985e2..08a060fa5 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -22,5 +22,5 @@ android { dependencies { implementation 'com.facebook.react:react-native:+' - implementation 'com.google.android.gms:play-services-ads:+' + implementation 'com.google.android.gms:play-services-ads:16.0.0' } From 2436592768485d321ca01bff79afef54d3b5584a Mon Sep 17 00:00:00 2001 From: sotatek-hieudo2 <68310554+sotatek-hieudo2@users.noreply.github.com> Date: Wed, 20 Oct 2021 11:54:12 +0700 Subject: [PATCH 4/6] Update RNPublisherBanner.js --- RNPublisherBanner.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/RNPublisherBanner.js b/RNPublisherBanner.js index 2a86bbaba..1de27230b 100644 --- a/RNPublisherBanner.js +++ b/RNPublisherBanner.js @@ -3,6 +3,7 @@ import React, { Component } from 'react'; import { findNodeHandle, UIManager, + requireNativeComponent, } from 'react-native'; import { createErrorFromErrorData } from './utils'; @@ -113,8 +114,6 @@ PublisherBanner.propTypes = { onAppEvent: func, }; -const requireNativeComponent = (str) => null; - const RNDFPBannerView = requireNativeComponent( 'RNDFPBannerView', PublisherBanner From 146192500fbba7cfe85e805497672d7084884e69 Mon Sep 17 00:00:00 2001 From: sotatek-hieudo2 <68310554+sotatek-hieudo2@users.noreply.github.com> Date: Wed, 20 Oct 2021 14:39:38 +0700 Subject: [PATCH 5/6] Update RNAdMobBanner.js --- RNAdMobBanner.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RNAdMobBanner.js b/RNAdMobBanner.js index ca081a99d..c204be81f 100644 --- a/RNAdMobBanner.js +++ b/RNAdMobBanner.js @@ -3,10 +3,11 @@ import React, { Component } from 'react'; import { findNodeHandle, UIManager, - requireNativeComponent, } from 'react-native'; import { createErrorFromErrorData } from './utils'; +const requireNativeComponent = require('react-native').requireNativeComponent; + class AdMobBanner extends Component { constructor() { super(); From 6d2a28bb450e819749c9f8599dede69adb202a98 Mon Sep 17 00:00:00 2001 From: sotatek-hieudo2 <68310554+sotatek-hieudo2@users.noreply.github.com> Date: Wed, 20 Oct 2021 14:40:01 +0700 Subject: [PATCH 6/6] Update RNPublisherBanner.js --- RNPublisherBanner.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RNPublisherBanner.js b/RNPublisherBanner.js index 1de27230b..706afbe55 100644 --- a/RNPublisherBanner.js +++ b/RNPublisherBanner.js @@ -3,10 +3,11 @@ import React, { Component } from 'react'; import { findNodeHandle, UIManager, - requireNativeComponent, } from 'react-native'; import { createErrorFromErrorData } from './utils'; +const requireNativeComponent = require('react-native').requireNativeComponent; + class PublisherBanner extends Component { constructor() { super();