Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysterious coverage drop? #268

Closed
nventuro opened this issue Aug 2, 2018 · 2 comments
Closed

Mysterious coverage drop? #268

nventuro opened this issue Aug 2, 2018 · 2 comments

Comments

@nventuro
Copy link

nventuro commented Aug 2, 2018

Hi!

On this OpenZeppelin PR, I noticed our coverage of a contract dropped to 0, though the changes to that file were insubstantial (in particular, the test that covers the related lines was not modified). Could you help us track this down so we can bump coverage up again?

Also, when testing locally I saw all of the mocks contracts were being skipped during the instrumentation phase, I take it this is so that coverage of those is not measured, and not a mistake?

Thanks a lot!

@nventuro
Copy link
Author

nventuro commented Aug 3, 2018

Turns out it was my fault all along, thanks @cgewecke for spotting it right away! I fixed it in this PR.

@nventuro nventuro closed this as completed Aug 3, 2018
@cgewecke
Copy link
Member

cgewecke commented Aug 3, 2018

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants