Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to toggle fields in syntax trees display mode #72

Open
jacobwegner opened this issue Oct 20, 2020 · 6 comments
Open

Add the ability to toggle fields in syntax trees display mode #72

jacobwegner opened this issue Oct 20, 2020 · 6 comments
Assignees

Comments

@jacobwegner
Copy link
Contributor

jacobwegner commented Oct 20, 2020

  • Add "toggle fields" to display mode toolbar
  • By default, don't show in the sentence or tree:
    • relationship
    • morph. tag
    • lemma
  • Allow a user to toggle on all or individual fields
  • When additional fields are toggled on, we will show them on hover in the sentence (increased line height)
    image
  • We will remove relationship from the tree by default
    image

Deliverable
New release of reader-syntax-trees-mode that can be installed into Explore Homer

Deployment Tasks (post-merge)

  • Update Explore Homer with the latest package
  • Deploy the newest data to Explore Homer ATLAS
@jacobwegner jacobwegner changed the title Add tag and lemma to syntax trees Add the ability to toggle fields in syntax trees display mode Oct 20, 2020
@jacobwegner
Copy link
Contributor Author

Currently blocked on data from ATLAS; I'll follow up once we have an endpoint with the new data structures

@jacobwegner jacobwegner added the BLOCKED Blocked on an external dependency label Oct 20, 2020
@jacobwegner
Copy link
Contributor Author

@paltman this is now unblocked.

You'll want to update to this temporary ATLAS endpoint:

https://sv-mini-atlas-pr-37.herokuapp.com/graphql/

Sample query showing new fields

image

The new fields in data are:

  • lemma
  • tag

@jacobwegner jacobwegner removed the BLOCKED Blocked on an external dependency label Oct 23, 2020
@jacobwegner jacobwegner self-assigned this Feb 15, 2021
@jacobwegner
Copy link
Contributor Author

@jtauber this has been deployed at the link below if you want to take a look:

https://scaife-stack.herokuapp.com/reader/urn:cts:greekLit:tlg0059.tlg003.pedalion-tb:43.1?mode=syntax-trees

@jtauber
Copy link
Member

jtauber commented Feb 24, 2021

Sorry I didn't comment here earlier, but this is looking great!

There are some style tweaks I want to make overall (not just to the toggles) but this is definitely demoable.

@jacobwegner
Copy link
Contributor Author

@jacobwegner
Copy link
Contributor Author

To load the newer data sets on Beyond Translation:

export VUE_APP_ATLAS_GRAPHQL_ENDPOINT="https://beyond-translation-gagdt-dev.herokuapp.com/graphql/"
yarn serve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants